about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <mwrap-perl@80x24.org>2022-12-16 22:57:54 +0000
committerEric Wong <mwrap-perl@80x24.org>2022-12-16 22:58:17 +0000
commit0805bec5595c4976e5215ca4e681b777d8bffac5 (patch)
tree4c44f1f41e513d86fcbfd18bad3453a0c2400178
parent4db2dadf3881ed18eefdc8fb78237b5fca4c3e78 (diff)
downloadmwrap-0805bec5595c4976e5215ca4e681b777d8bffac5.tar.gz
Sometimes, stale sockets can stick around and the PID gets
recycled by a different process, so ensure we can actually
connect to it before listing it.
-rw-r--r--lib/Devel/Mwrap/Rproxy.pm10
1 files changed, 7 insertions, 3 deletions
diff --git a/lib/Devel/Mwrap/Rproxy.pm b/lib/Devel/Mwrap/Rproxy.pm
index 76b7d7f..6db72e6 100644
--- a/lib/Devel/Mwrap/Rproxy.pm
+++ b/lib/Devel/Mwrap/Rproxy.pm
@@ -41,11 +41,15 @@ sub list {
         open(my $fh, '+>', \(my $str)) or die "open: $!";
         print $fh '<html><head><title>', $t, '</title></head><body><pre>', $t,
                 "\n\n";
-        opendir(my $dh, $self->{socket_dir}) or return r(500, "socket_dir: $!");
-        my @pids = grep(/\A[0-9]+\.sock\z/, readdir($dh));
-        for (@pids) {
+        my $dir = $self->{socket_dir};
+        opendir(my $dh, $dir) or return r(500, "socket_dir: $!");
+        my @socks = grep(/\A[0-9]+\.sock\z/, readdir($dh));
+        my %o = (Type => SOCK_STREAM, Peer => undef);
+        for (@socks) {
+                $o{Peer} = "$dir/$_";
                 substr($_, -5, 5, ''); # chop off .sock
                 my $cmd = $valid_pid->($_) // next;
+                my $c = IO::Socket::UNIX->new(%o) // next;
                 print $fh qq(<a\nhref="./$_/">$_</a>/);
                 $_ .= '/each/2000';
                 say $fh qq(<a\nhref="./), $_, qq(">each/2000</a>\t), $cmd;