mwrap user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [PATCH 0/2] refining the httpd interface
@ 2023-01-09  6:21 Eric Wong
  2023-01-09  6:21 ` [PATCH 1/2] httpd: add notes about arenas and object heaps Eric Wong
  2023-01-09  6:21 ` [PATCH 2/2] httpd: add CSV download link to /each/$MIN HTML Eric Wong
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Wong @ 2023-01-09  6:21 UTC (permalink / raw)
  To: mwrap-public

Being edumacational :P

Eric Wong (2):
  httpd: add notes about arenas and object heaps
  httpd: add CSV download link to /each/$MIN HTML

 ext/mwrap/httpd.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] httpd: add notes about arenas and object heaps
  2023-01-09  6:21 [PATCH 0/2] refining the httpd interface Eric Wong
@ 2023-01-09  6:21 ` Eric Wong
  2023-01-09  6:21 ` [PATCH 2/2] httpd: add CSV download link to /each/$MIN HTML Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Wong @ 2023-01-09  6:21 UTC (permalink / raw)
  To: mwrap-public

We don't users being confused if an innocuous-looking
line of code allocates unnexpectedly large values.
---
 ext/mwrap/httpd.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/ext/mwrap/httpd.h b/ext/mwrap/httpd.h
index 17fb187..fe4fe2f 100644
--- a/ext/mwrap/httpd.h
+++ b/ext/mwrap/httpd.h
@@ -600,7 +600,12 @@ static enum mw_qev each_at(struct mw_h1 *h1, struct mw_h1req *h1r)
 				size, h->as.live.gen, h->real);
 	}
 	rcu_read_unlock();
-	FPUTS("</table></body></html>", fp);
+	FPUTS("</table><pre>\nNotes:\n"
+"* 16344-byte (64-bit) or 16344-byte (32-bit) allocations in\n"
+"  Ruby &lt;= 3.0 aligned to 0x4000 are likely for object heap slots.\n"
+"* 4080-byte allocations in Perl 5 are likely for arenas\n"
+"  (set via the PERL_ARENA_SIZE compile-time macro)"
+"</pre></body></html>", fp);
 	return h1_200(h1, &html, TYPE_HTML);
 }
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] httpd: add CSV download link to /each/$MIN HTML
  2023-01-09  6:21 [PATCH 0/2] refining the httpd interface Eric Wong
  2023-01-09  6:21 ` [PATCH 1/2] httpd: add notes about arenas and object heaps Eric Wong
@ 2023-01-09  6:21 ` Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Wong @ 2023-01-09  6:21 UTC (permalink / raw)
  To: mwrap-public

This makes the .CSV download discoverable so I don't have
to document it in the manpage \o/
---
 ext/mwrap/httpd.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ext/mwrap/httpd.h b/ext/mwrap/httpd.h
index fe4fe2f..ef4d83c 100644
--- a/ext/mwrap/httpd.h
+++ b/ext/mwrap/httpd.h
@@ -654,7 +654,8 @@ static enum mw_qev each_gt(struct mw_h1 *h1, struct mw_h1req *h1r,
 		fprintf(fp, "<html><head><title>mwrap each &gt;%lu"
 			"</title></head><body><p>mwrap each &gt;%lu "
 			"(change `%lu' in URL to adjust filtering) - "
-			"MWRAP=bt:%u", min, min, min, depth);
+			"MWRAP=bt:%u <a href=\"%lu.csv\">.csv</a>",
+			min, min, min, depth, min);
 		show_stats(fp);
 		/* need borders to distinguish multi-level traces */
 		if (depth)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-09  6:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09  6:21 [PATCH 0/2] refining the httpd interface Eric Wong
2023-01-09  6:21 ` [PATCH 1/2] httpd: add notes about arenas and object heaps Eric Wong
2023-01-09  6:21 ` [PATCH 2/2] httpd: add CSV download link to /each/$MIN HTML Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).