From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 1/4] rproxy: bail out early on errors reading /proc/$$/cmdline
Date: Wed, 28 Dec 2022 10:05:32 +0000 [thread overview]
Message-ID: <20221228100535.2252158-2-e@80x24.org> (raw)
In-Reply-To: <20221228100535.2252158-1-e@80x24.org>
I'm not sure if it's really an issue, but it it narrows down
the places where uninitialized variable warnings can happen.
---
lib/Devel/Mwrap/Rproxy.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Devel/Mwrap/Rproxy.pm b/lib/Devel/Mwrap/Rproxy.pm
index c96a947..29225c1 100644
--- a/lib/Devel/Mwrap/Rproxy.pm
+++ b/lib/Devel/Mwrap/Rproxy.pm
@@ -29,7 +29,7 @@ my $valid_pid = $^O eq 'linux' ? sub {
my ($pid) = @_;
if (open(my $fh, '<', "/proc/$pid/cmdline")) {
local $/;
- my $str = <$fh>;
+ my $str = <$fh> // return;
$str =~ tr/\0/ /;
Plack::Util::encode_html($str);
}
next prev parent reply other threads:[~2022-12-28 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 10:05 [PATCH 0/4] rproxy: addr2line support improvements Eric Wong
2022-12-28 10:05 ` Eric Wong [this message]
2022-12-28 10:05 ` [PATCH 2/4] rproxy: close pipes in deterministic order Eric Wong
2022-12-28 10:05 ` [PATCH 3/4] rproxy: improve addr2line support Eric Wong
2022-12-28 10:05 ` [PATCH 4/4] rproxy: cache addr2line output Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228100535.2252158-2-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).