From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2580F1FA27 for ; Wed, 28 Dec 2022 10:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1672221935; bh=485aAlmPgwmuD6iSUdEX4Qx6IUiYKdG322X7EAw1OmM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Gy0F7wiEdIAJeWFHFXjpQYNxMD+DvsxZe0k8IBnG+z6PmribGbb0pJb+mdk8K6vTG zuwjbkOX2ejGQPCC8QSR12V8s/qkTOLua+3gduDbO3z/VYUrryGf9WHvg7jTQIUa9u o9UYSL/1znOjaSePlpmQJ0RS+yboxTz2W++8X/AM= From: Eric Wong To: mwrap-perl@80x24.org Subject: [PATCH 1/4] rproxy: bail out early on errors reading /proc/$$/cmdline Date: Wed, 28 Dec 2022 10:05:32 +0000 Message-Id: <20221228100535.2252158-2-e@80x24.org> In-Reply-To: <20221228100535.2252158-1-e@80x24.org> References: <20221228100535.2252158-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: I'm not sure if it's really an issue, but it it narrows down the places where uninitialized variable warnings can happen. --- lib/Devel/Mwrap/Rproxy.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Devel/Mwrap/Rproxy.pm b/lib/Devel/Mwrap/Rproxy.pm index c96a947..29225c1 100644 --- a/lib/Devel/Mwrap/Rproxy.pm +++ b/lib/Devel/Mwrap/Rproxy.pm @@ -29,7 +29,7 @@ my $valid_pid = $^O eq 'linux' ? sub { my ($pid) = @_; if (open(my $fh, '<', "/proc/$pid/cmdline")) { local $/; - my $str = <$fh>; + my $str = <$fh> // return; $str =~ tr/\0/ /; Plack::Util::encode_html($str); }