From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 5/5] mwrap_httpd: report ftello error
Date: Mon, 12 Dec 2022 11:40:56 +0000 [thread overview]
Message-ID: <20221212114056.9615-6-e@80x24.org> (raw)
In-Reply-To: <20221212114056.9615-1-e@80x24.org>
ftello(3) may fail if out-of-memory.
---
mwrap_httpd.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mwrap_httpd.h b/mwrap_httpd.h
index 6d40d6c..bfa723d 100644
--- a/mwrap_httpd.h
+++ b/mwrap_httpd.h
@@ -429,8 +429,10 @@ static off_t write_loc_name(FILE *fp, const struct src_loc *l)
free(s);
}
off_t end = ftello(fp);
- if (end < 0)
+ if (end < 0) {
+ fprintf(stderr, "ftello: %m\n");
return end;
+ }
return end - beg;
}
prev parent reply other threads:[~2022-12-12 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 11:40 [PATCH 0/5] a few odds and ends before full backtrace support Eric Wong
2022-12-12 11:40 ` [PATCH 1/5] httpd: hoist out err_close from ferror|fclose Eric Wong
2022-12-12 11:40 ` [PATCH 2/5] httpd: consolidate open_memstream error checking Eric Wong
2022-12-12 11:40 ` [PATCH 3/5] use `%m' for *printf rather than strerror(errno) Eric Wong
2022-12-12 11:40 ` [PATCH 4/5] httpd: mw_h1req comment fixes Eric Wong
2022-12-12 11:40 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212114056.9615-6-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).