From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 1/5] httpd: hoist out err_close from ferror|fclose
Date: Mon, 12 Dec 2022 11:40:52 +0000 [thread overview]
Message-ID: <20221212114056.9615-2-e@80x24.org> (raw)
In-Reply-To: <20221212114056.9615-1-e@80x24.org>
A small tweak to simplify error reporting if we have any
problems due to OOM or bugs.
---
mwrap_httpd.h | 29 ++++++++++++++---------------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/mwrap_httpd.h b/mwrap_httpd.h
index 6856208..b55bb02 100644
--- a/mwrap_httpd.h
+++ b/mwrap_httpd.h
@@ -212,6 +212,13 @@ static FILE *wbuf_new(struct mw_membuf *mb)
return fp;
}
+static int err_close(FILE *fp)
+{
+ int e = ferror(fp) | fclose(fp);
+ if (e) fprintf(stderr, "ferror|fclose: %m\n");
+ return e;
+}
+
static enum mw_qev h1_res_oneshot(struct mw_h1 *h1, const char *buf, size_t len)
{
struct mw_membuf mb;
@@ -220,10 +227,8 @@ static enum mw_qev h1_res_oneshot(struct mw_h1 *h1, const char *buf, size_t len)
if (!fp)
return h1_close(h1);
fwrite(buf, 1, len, fp);
- if (ferror(fp) | fclose(fp)) {
- fprintf(stderr, "ferror|fclose: %m\n");
+ if (err_close(fp))
return h1_close(h1);
- }
/* fill in the zero padding we added at wbuf_new */
mwrap_assert(!h1->wbuf);
@@ -258,10 +263,8 @@ static enum mw_qev h1_200(struct mw_h1 *h1, FILE *fp, struct mw_membuf *mb)
fprintf(fp, "%zu", (size_t)clen);
FPUTS("\r\n\r\n", fp);
- if (ferror(fp) | fclose(fp)) {
- fprintf(stderr, "ferror|fclose: %m\n");
+ if (err_close(fp))
return h1_close(h1);
- }
/* fill in the zero-padding we added at wbuf_new */
mwrap_assert(!h1->wbuf);
@@ -462,8 +465,7 @@ static struct h1_src_loc *accumulate(unsigned long min, size_t *hslc, FILE *lp)
rcu_read_unlock();
struct h1_src_loc *hslv;
- if (ferror(fp) | fclose(fp)) {
- fprintf(stderr, "ferror|fclose: %m\n");
+ if (err_close(fp)) {
hslv = NULL;
} else {
*hslc = mb.len / sizeof(*hslv);
@@ -489,10 +491,9 @@ static enum mw_qev each_at(struct mw_h1 *h1, struct mw_h1req *h1r)
FILE *lp = open_memstream(&lname.ptr, &lname.len);
if (!lp) return h1_close(h1);
if (write_loc_name(lp, l) < 0) return h1_close(h1);
- if (ferror(lp) | fclose(lp)) {
- fprintf(stderr, "ferror|fclose: %m\n");
+ if (err_close(lp))
return h1_close(h1);
- }
+
struct mw_membuf mb;
FILE *fp = wbuf_new(&mb);
if (!fp) return h1_close(h1);
@@ -544,8 +545,7 @@ static enum mw_qev each_gt(struct mw_h1 *h1, struct mw_h1req *h1r,
if (!hslv)
return h1_close(h1);
- if (ferror(lp) | fclose(lp)) {
- fprintf(stderr, "ferror|fclose: %m\n");
+ if (err_close(lp)) {
free(hslv);
return h1_close(h1);
}
@@ -863,8 +863,7 @@ static struct pollfd *poll_detach(struct mw_h1d *h1d, nfds_t *nfds)
/* not sure how to best recover from ENOMEM errors in stdio */
if (h1d->pfp) {
- if (ferror(h1d->pfp) | fclose(h1d->pfp)) {
- fprintf(stderr, "ferror|fclose: %m\n");
+ if (err_close(h1d->pfp)) {
exit(EXIT_FAILURE);
} else {
mwrap_assert(h1d->pbuf.len % sizeof(*pfd) == 0);
next prev parent reply other threads:[~2022-12-12 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 11:40 [PATCH 0/5] a few odds and ends before full backtrace support Eric Wong
2022-12-12 11:40 ` Eric Wong [this message]
2022-12-12 11:40 ` [PATCH 2/5] httpd: consolidate open_memstream error checking Eric Wong
2022-12-12 11:40 ` [PATCH 3/5] use `%m' for *printf rather than strerror(errno) Eric Wong
2022-12-12 11:40 ` [PATCH 4/5] httpd: mw_h1req comment fixes Eric Wong
2022-12-12 11:40 ` [PATCH 5/5] mwrap_httpd: report ftello error Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212114056.9615-2-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).