mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 5/6] mwrap_get: golf out redundant assignment across branches
Date: Wed, 16 Nov 2022 09:26:45 +0000	[thread overview]
Message-ID: <20221116092646.19919-6-e@80x24.org> (raw)
In-Reply-To: <20221116092646.19919-1-e@80x24.org>

Terminal space is precious with my font sizes.
---
 Mwrap.xs | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Mwrap.xs b/Mwrap.xs
index a5ffeed..c8a4568 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -147,7 +147,7 @@ mwrap_get(loc)
 PREINIT:
 	STRLEN len;
 	const char *str;
-	struct src_loc *k = 0;
+	struct src_loc *k = (void *)kbuf;
 	uintptr_t p;
 	struct cds_lfht_iter iter;
 	struct cds_lfht_node *cur;
@@ -161,12 +161,10 @@ CODE:
 	if (len > PATH_MAX)
 		XSRETURN_UNDEF;
 	if (extract_addr(str, len, (void **)&p)) {
-		k = (void *)kbuf;
 		memcpy(k->k, &p, sizeof(p));
 		k->capa = 0;
 		hash_loc(k, sizeof(p));
 	} else {
-		k = (void *)kbuf;
 		memcpy(k->k, str, len + 1);
 		k->capa = len + 1;
 		hash_loc(k, k->capa);

  parent reply	other threads:[~2022-11-16  9:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16  9:26 [PATCH 0/6] another batch of fixes Eric Wong
2022-11-16  9:26 ` [PATCH 1/6] avoid leaking array returned by backtrace_symbols() Eric Wong
2022-11-16  9:26 ` [PATCH 2/6] mwrap_core: document the reason for padding the mutex Eric Wong
2022-11-16  9:26 ` [PATCH 3/6] wrap jhash calls to hash_loc Eric Wong
2022-11-16  9:26 ` [PATCH 4/6] fix under-allocated kbuf size Eric Wong
2022-11-16  9:26 ` Eric Wong [this message]
2022-11-16  9:26 ` [PATCH 6/6] location_name: handle malloc failure on backtrace_symbols(3) Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116092646.19919-6-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).