From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 1/6] avoid leaking array returned by backtrace_symbols()
Date: Wed, 16 Nov 2022 09:26:41 +0000 [thread overview]
Message-ID: <20221116092646.19919-2-e@80x24.org> (raw)
In-Reply-To: <20221116092646.19919-1-e@80x24.org>
Oops :x Fortunately, most allocations are tracked to a Perl
location and the non-Perl code path is infrequently hit.
---
Mwrap.xs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Mwrap.xs b/Mwrap.xs
index d5336fa..8aeb425 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -20,8 +20,8 @@ static SV *location_string(struct src_loc *l)
char **s = backtrace_symbols((void *)l->k, 1);
ret = newSVpvn(s[0], strlen(s[0]));
- }
- else {
+ free(s);
+ } else {
ret = newSVpvn(l->k, l->capa - 1);
}
next prev parent reply other threads:[~2022-11-16 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 9:26 [PATCH 0/6] another batch of fixes Eric Wong
2022-11-16 9:26 ` Eric Wong [this message]
2022-11-16 9:26 ` [PATCH 2/6] mwrap_core: document the reason for padding the mutex Eric Wong
2022-11-16 9:26 ` [PATCH 3/6] wrap jhash calls to hash_loc Eric Wong
2022-11-16 9:26 ` [PATCH 4/6] fix under-allocated kbuf size Eric Wong
2022-11-16 9:26 ` [PATCH 5/6] mwrap_get: golf out redundant assignment across branches Eric Wong
2022-11-16 9:26 ` [PATCH 6/6] location_name: handle malloc failure on backtrace_symbols(3) Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116092646.19919-2-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).