mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 7/7] psgi: show address column
Date: Tue,  5 Oct 2021 12:48:03 +0000	[thread overview]
Message-ID: <20211005124803.7215-8-e@80x24.org> (raw)
In-Reply-To: <20211005124803.7215-1-e@80x24.org>

These addresses are useful for plugging into gdb while
gdb is hooked up to a live process.  For example:

	echo 'print (char *)(0xdeadbeef+48)' | gdb -p $PID

Will show the pointer part of an SV
---
 Mwrap.xs                | 5 ++---
 lib/Devel/Mwrap/PSGI.pm | 7 ++++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Mwrap.xs b/Mwrap.xs
index 43d1ed6..bb51930 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -1049,9 +1049,7 @@ CODE:
 	++locating;
 	rcu_read_lock();
 	cds_list_for_each_entry_rcu(h, &self->allocs, anode) {
-		size_t gen = uatomic_read(&h->as.live.gen);
 		size_t size = uatomic_read(&h->size);
-
 		if (size > min) {
 			dSP;
 			ENTER;
@@ -1065,7 +1063,8 @@ CODE:
 			 */
 			XPUSHs(arg);
 			XPUSHs(sv_2mortal(newSVuv(size)));
-			XPUSHs(sv_2mortal(newSVuv(gen)));
+			XPUSHs(sv_2mortal(newSVuv(h->as.live.gen)));
+			XPUSHs(sv_2mortal(newSVuv((uintptr_t)h->real)));
 			PUTBACK;
 
 			call_sv(cb, G_DISCARD|G_EVAL);
diff --git a/lib/Devel/Mwrap/PSGI.pm b/lib/Devel/Mwrap/PSGI.pm
index 52dbebe..12bb929 100644
--- a/lib/Devel/Mwrap/PSGI.pm
+++ b/lib/Devel/Mwrap/PSGI.pm
@@ -121,8 +121,9 @@ EOM
 }
 
 sub each_at_i {
-	my ($fh, $size, $gen) = @_;
-	print $fh "<tr><td>$size</td><td>$gen</td></tr>\n";
+	my ($fh, $size, $gen, $addr) = @_;
+	print $fh "<tr><td>$size</td><td>$gen</td><td>";
+	printf $fh "0x%lx</td></tr>\n", $addr;
 }
 
 sub each_at {
@@ -134,7 +135,7 @@ sub each_at {
 	print $fh <<EOM;
 <html><head><title>$t</title></head><body><p>live allocations at $t
 <p>Current age: $age (live: $live)\n<table>
-<tr><th>size</th><th>generation</th></tr>
+<tr><th>size</th><th>generation</th><th>address</th></tr>
 EOM
 	$src_loc->each(0, \&each_at_i, $fh);
 	print $fh "</table></body></html>\n";

      parent reply	other threads:[~2021-10-05 12:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 12:47 [PATCH 0/7] PSGI-related updates Eric Wong
2021-10-05 12:47 ` [PATCH 1/7] don't set root_locating until BOOT Eric Wong
2021-10-05 12:47 ` [PATCH 2/7] examples/mwrap.psgi: explain why we delete LD_PRELOAD Eric Wong
2021-10-05 12:47 ` [PATCH 3/7] psgi: fix 404 return Eric Wong
2021-10-05 12:48 ` [PATCH 4/7] examples/mwrap.psgi: disable deflater Eric Wong
2021-10-05 12:48 ` [PATCH 5/7] psgi: add total bytes + reset Eric Wong
2021-10-05 12:48 ` [PATCH 6/7] psgi: sort "location" column lexically Eric Wong
2021-10-05 12:48 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005124803.7215-8-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).