mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 6/7] psgi: sort "location" column lexically
Date: Tue,  5 Oct 2021 12:48:02 +0000	[thread overview]
Message-ID: <20211005124803.7215-7-e@80x24.org> (raw)
In-Reply-To: <20211005124803.7215-1-e@80x24.org>

It's probably not worth sorting line numbers for
location.
---
 lib/Devel/Mwrap/PSGI.pm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/Devel/Mwrap/PSGI.pm b/lib/Devel/Mwrap/PSGI.pm
index 5bb7c36..52dbebe 100644
--- a/lib/Devel/Mwrap/PSGI.pm
+++ b/lib/Devel/Mwrap/PSGI.pm
@@ -92,7 +92,11 @@ sub each_gt {
 	} @f));
 	my @all;
 	Devel::Mwrap::each($min, \&accumulate_i, \@all);
-	@all = sort { $b->[$sc] <=> $a->[$sc] } @all;
+	if ($sc eq $#FIELDS) { # locations are sorted alphabetically
+		@all = sort { $a->[$sc] cmp $b->[$sc] } @all;
+	} else { # everything else is numeric
+		@all = sort { $b->[$sc] <=> $a->[$sc] } @all;
+	}
 	my $age = Devel::Mwrap::current_age();
 	my $live = $age - Devel::Mwrap::total_bytes_freed();
 	print $fh <<EOM;

  parent reply	other threads:[~2021-10-05 12:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 12:47 [PATCH 0/7] PSGI-related updates Eric Wong
2021-10-05 12:47 ` [PATCH 1/7] don't set root_locating until BOOT Eric Wong
2021-10-05 12:47 ` [PATCH 2/7] examples/mwrap.psgi: explain why we delete LD_PRELOAD Eric Wong
2021-10-05 12:47 ` [PATCH 3/7] psgi: fix 404 return Eric Wong
2021-10-05 12:48 ` [PATCH 4/7] examples/mwrap.psgi: disable deflater Eric Wong
2021-10-05 12:48 ` [PATCH 5/7] psgi: add total bytes + reset Eric Wong
2021-10-05 12:48 ` Eric Wong [this message]
2021-10-05 12:48 ` [PATCH 7/7] psgi: show address column Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005124803.7215-7-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).