meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Qi.Chen@windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] kubernetes: do not strip binaries at build
Date: Tue, 4 Jul 2023 22:45:05 -0400	[thread overview]
Message-ID: <CADkTA4Mtbt2QGDT8RyrkqivatKFKbJD95y6fuxNzKKAyDCHQ2g@mail.gmail.com> (raw)
In-Reply-To: <20230628032936.3257233-1-Qi.Chen@windriver.com>

I haven't forgotten about these.

I'm going through an uprev cycle for many of the packages (and the
kernel), so I've been fighting a few issues.

If I can't get the other issues resolved, I will bump the priority on
these and merge them wednesday.

Bruce

On Tue, Jun 27, 2023 at 11:30 PM Chen Qi via lists.yoctoproject.org
<Qi.Chen=windriver.com@lists.yoctoproject.org> wrote:
>
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Yocto/OE has its own way to control binary stripping. So don't do
> it in the go build process. Otherwise, we'll get empty dbg packages.
>
> Setting DBG=1 solves this problem, as stated in comments in the Makefile.
> """
>   # Note: Specify DBG=1 for building unstripped binaries, which allows you to use code debugging
>   # tools like delve. When DBG is unspecified, it defaults to "-s -w" which strips debug
>   # information.
> """
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  recipes-containers/kubernetes/kubernetes_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb
> index 3a6e711..8b7c9e0 100644
> --- a/recipes-containers/kubernetes/kubernetes_git.bb
> +++ b/recipes-containers/kubernetes/kubernetes_git.bb
> @@ -87,7 +87,7 @@ do_compile() {
>         export GOBIN=""
>
>         # to limit what is built, use 'WHAT', i.e. make WHAT=cmd/kubelet
> -       make cross CGO_FLAGS=${CGO_FLAGS} GO=${GO} KUBE_BUILD_PLATFORMS=${GOOS}/${GOARCH} GOLDFLAGS=""
> +       make cross CGO_FLAGS=${CGO_FLAGS} GO=${GO} KUBE_BUILD_PLATFORMS=${GOOS}/${GOARCH} GOLDFLAGS="" DBG=1
>  }
>
>  do_install() {
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8113): https://lists.yoctoproject.org/g/meta-virtualization/message/8113
> Mute This Topic: https://lists.yoctoproject.org/mt/99823673/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


      reply	other threads:[~2023-07-05  2:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  3:29 [meta-virtualization][PATCH] kubernetes: do not strip binaries at build Qi.Chen
2023-07-05  2:45 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADkTA4Mtbt2QGDT8RyrkqivatKFKbJD95y6fuxNzKKAyDCHQ2g@mail.gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=Qi.Chen@windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).