meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Qi.Chen@windriver.com
To: meta-virtualization@lists.yoctoproject.org
Subject: [meta-virtualization][PATCH] kubernetes: do not strip binaries at build
Date: Wed, 28 Jun 2023 11:29:36 +0800	[thread overview]
Message-ID: <20230628032936.3257233-1-Qi.Chen@windriver.com> (raw)

From: Chen Qi <Qi.Chen@windriver.com>

Yocto/OE has its own way to control binary stripping. So don't do
it in the go build process. Otherwise, we'll get empty dbg packages.

Setting DBG=1 solves this problem, as stated in comments in the Makefile.
"""
  # Note: Specify DBG=1 for building unstripped binaries, which allows you to use code debugging
  # tools like delve. When DBG is unspecified, it defaults to "-s -w" which strips debug
  # information.
"""

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 recipes-containers/kubernetes/kubernetes_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb
index 3a6e711..8b7c9e0 100644
--- a/recipes-containers/kubernetes/kubernetes_git.bb
+++ b/recipes-containers/kubernetes/kubernetes_git.bb
@@ -87,7 +87,7 @@ do_compile() {
 	export GOBIN=""
 
 	# to limit what is built, use 'WHAT', i.e. make WHAT=cmd/kubelet
-	make cross CGO_FLAGS=${CGO_FLAGS} GO=${GO} KUBE_BUILD_PLATFORMS=${GOOS}/${GOARCH} GOLDFLAGS=""
+	make cross CGO_FLAGS=${CGO_FLAGS} GO=${GO} KUBE_BUILD_PLATFORMS=${GOOS}/${GOARCH} GOLDFLAGS="" DBG=1
 }
 
 do_install() {
-- 
2.34.1



             reply	other threads:[~2023-06-28  3:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  3:29 Qi.Chen [this message]
2023-07-05  2:45 ` [meta-virtualization][PATCH] kubernetes: do not strip binaries at build Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230628032936.3257233-1-Qi.Chen@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).