From: Jan Beulich <jbeulich@suse.com>
To: Carlo Nonato <carlo.nonato@minervasys.tech>
Cc: andrea.bastoni@minervasys.tech,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Marco Solieri <marco.solieri@minervasys.tech>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v8 04/13] xen/arm: add Dom0 cache coloring support
Date: Tue, 14 May 2024 09:02:14 +0200 [thread overview]
Message-ID: <79ff7ec2-e4d4-4407-a5a1-98027c0a8c97@suse.com> (raw)
In-Reply-To: <CAG+AhRX3oUiGxwYphQDcKo_W+4V3kzMoDh_NVGQcCBXxYT0YAg@mail.gmail.com>
On 06.05.2024 17:53, Carlo Nonato wrote:
> Hi Jan,
>
> On Mon, May 6, 2024 at 2:01 PM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 02.05.2024 18:55, Carlo Nonato wrote:
>>> Add a command line parameter to allow the user to set the coloring
>>> configuration for Dom0.
>>> A common configuration syntax for cache colors is introduced and
>>> documented.
>>> Take the opportunity to also add:
>>> - default configuration notion.
>>> - function to check well-formed configurations.
>>>
>>> Direct mapping Dom0 isn't possible when coloring is enabled, so
>>> CDF_directmap flag is removed when creating it.
>>>
>>> Based on original work from: Luca Miccio <lucmiccio@gmail.com>
>>>
>>> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
>>> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
>>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> albeit ...
>>
>>> v8:
>>> - added bound check on dom0_num_colors
>>> - default colors array set just once
>>> v7:
>>> - parse_color_config() doesn't accept leading/trailing commas anymore
>>> - removed alloc_colors() helper
>>> v6:
>>> - moved domain_llc_coloring_free() in this patch
>>
>> ... I'm having trouble seeing why this was done: Dom0 isn't ever cleaned up
>> after, is it?
>
> domain_destroy() is never called for dom0, right?
Indeed, with perhaps the exception of late hwdom (assuming that feature hasn't
bit-rotted).
Jan
> If so, yes this is wrongly placed here.
>
> Thanks.
>
>> Jan
next prev parent reply other threads:[~2024-05-14 7:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 16:55 [PATCH v8 00/13] Arm cache coloring Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 01/13] xen/common: add cache coloring common code Carlo Nonato
2024-05-06 11:54 ` Jan Beulich
2024-05-06 15:53 ` Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 02/13] xen/arm: add initial support for LLC coloring on arm64 Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 03/13] xen/arm: permit non direct-mapped Dom0 construction Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 04/13] xen/arm: add Dom0 cache coloring support Carlo Nonato
2024-05-06 12:01 ` Jan Beulich
2024-05-06 15:53 ` Carlo Nonato
2024-05-14 7:02 ` Jan Beulich [this message]
2024-05-02 16:55 ` [PATCH v8 05/13] xen: extend domctl interface for cache coloring Carlo Nonato
2024-05-06 12:05 ` Jan Beulich
2024-05-02 16:55 ` [PATCH v8 06/13] tools: add support for cache coloring configuration Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 07/13] xen/arm: add support for cache coloring configuration via device-tree Carlo Nonato
2024-05-06 12:11 ` Jan Beulich
2024-05-02 16:55 ` [PATCH v8 08/13] xen/page_alloc: introduce preserved page flags macro Carlo Nonato
2024-05-06 12:22 ` Jan Beulich
2024-05-06 15:54 ` Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 09/13] xen: add cache coloring allocator for domains Carlo Nonato
2024-05-06 12:46 ` Jan Beulich
2024-05-02 16:55 ` [PATCH v8 10/13] xen/arm: use domain memory to allocate p2m page tables Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 11/13] xen/arm: add Xen cache colors command line parameter Carlo Nonato
2024-05-06 13:24 ` Jan Beulich
2024-05-02 16:55 ` [PATCH v8 12/13] xen/arm: make consider_modules() available for xen relocation Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 13/13] xen/arm: add cache coloring support for Xen Carlo Nonato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79ff7ec2-e4d4-4407-a5a1-98027c0a8c97@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrea.bastoni@minervasys.tech \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=carlo.nonato@minervasys.tech \
--cc=george.dunlap@citrix.com \
--cc=julien@xen.org \
--cc=marco.solieri@minervasys.tech \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).