From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: andrea.bastoni@minervasys.tech,
Carlo Nonato <carlo.nonato@minervasys.tech>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Marco Solieri <marco.solieri@minervasys.tech>
Subject: [PATCH v8 05/13] xen: extend domctl interface for cache coloring
Date: Thu, 2 May 2024 18:55:25 +0200 [thread overview]
Message-ID: <20240502165533.319988-6-carlo.nonato@minervasys.tech> (raw)
In-Reply-To: <20240502165533.319988-1-carlo.nonato@minervasys.tech>
Add a new domctl hypercall to allow the user to set LLC coloring
configurations. Colors can be set only once, just after domain creation,
since recoloring isn't supported.
Based on original work from: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
---
v8:
- fixed memory leak on error path of domain_set_llc_colors()
v7:
- -EOPNOTSUPP returned in case of hypercall called without llc_coloring_enabled
- domain_set_llc_colors_domctl() renamed to domain_set_llc_colors()
- added padding and input bound checks to domain_set_llc_colors()
- removed alloc_colors() helper usage from domain_set_llc_colors()
v6:
- reverted the XEN_DOMCTL_INTERFACE_VERSION bump
- reverted to uint32 for the guest handle
- explicit padding added to the domctl struct
- rewrote domain_set_llc_colors_domctl() to be more explicit
v5:
- added a new hypercall to set colors
- uint for the guest handle
v4:
- updated XEN_DOMCTL_INTERFACE_VERSION
---
xen/common/domctl.c | 10 ++++++++
xen/common/llc-coloring.c | 46 +++++++++++++++++++++++++++++++---
xen/include/public/domctl.h | 9 +++++++
xen/include/xen/llc-coloring.h | 2 ++
4 files changed, 64 insertions(+), 3 deletions(-)
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 2c0331bb05..30cca9a4ae 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -8,6 +8,7 @@
#include <xen/types.h>
#include <xen/lib.h>
+#include <xen/llc-coloring.h>
#include <xen/err.h>
#include <xen/mm.h>
#include <xen/sched.h>
@@ -864,6 +865,15 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
__HYPERVISOR_domctl, "h", u_domctl);
break;
+ case XEN_DOMCTL_set_llc_colors:
+ if ( op->u.set_llc_colors.pad )
+ ret = -EINVAL;
+ else if ( llc_coloring_enabled )
+ ret = domain_set_llc_colors(d, &op->u.set_llc_colors);
+ else
+ ret = -EOPNOTSUPP;
+ break;
+
default:
ret = arch_do_domctl(op, d, u_domctl);
break;
diff --git a/xen/common/llc-coloring.c b/xen/common/llc-coloring.c
index 26270cda9c..ecfeb0ce82 100644
--- a/xen/common/llc-coloring.c
+++ b/xen/common/llc-coloring.c
@@ -4,6 +4,7 @@
*
* Copyright (C) 2022 Xilinx Inc.
*/
+#include <xen/guest_access.h>
#include <xen/keyhandler.h>
#include <xen/llc-coloring.h>
#include <xen/param.h>
@@ -103,8 +104,7 @@ static void print_colors(const unsigned int *colors, unsigned int num_colors)
printk(" }\n");
}
-static bool __init check_colors(const unsigned int *colors,
- unsigned int num_colors)
+static bool check_colors(const unsigned int *colors, unsigned int num_colors)
{
unsigned int i;
@@ -180,7 +180,7 @@ void domain_dump_llc_colors(const struct domain *d)
print_colors(d->llc_colors, d->num_llc_colors);
}
-static void __init domain_set_default_colors(struct domain *d)
+static void domain_set_default_colors(struct domain *d)
{
printk(XENLOG_WARNING
"LLC color config not found for %pd, using all colors\n", d);
@@ -226,6 +226,46 @@ void domain_llc_coloring_free(struct domain *d)
xfree(__va(__pa(d->llc_colors)));
}
+int domain_set_llc_colors(struct domain *d,
+ const struct xen_domctl_set_llc_colors *config)
+{
+ unsigned int *colors;
+
+ if ( d->num_llc_colors )
+ return -EEXIST;
+
+ if ( !config->num_llc_colors )
+ {
+ domain_set_default_colors(d);
+ return 0;
+ }
+
+ if ( config->num_llc_colors > max_nr_colors )
+ return -EINVAL;
+
+ colors = xmalloc_array(unsigned int, config->num_llc_colors);
+ if ( !colors )
+ return -ENOMEM;
+
+ if ( copy_from_guest(colors, config->llc_colors, config->num_llc_colors) )
+ {
+ xfree(colors);
+ return -EFAULT;
+ }
+
+ if ( !check_colors(colors, config->num_llc_colors) )
+ {
+ printk(XENLOG_ERR "Bad LLC color config for %pd\n", d);
+ xfree(colors);
+ return -EINVAL;
+ }
+
+ d->llc_colors = colors;
+ d->num_llc_colors = config->num_llc_colors;
+
+ return 0;
+}
+
/*
* Local variables:
* mode: C
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index a33f9ec32b..d44eac8775 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1190,6 +1190,13 @@ struct xen_domctl_vmtrace_op {
typedef struct xen_domctl_vmtrace_op xen_domctl_vmtrace_op_t;
DEFINE_XEN_GUEST_HANDLE(xen_domctl_vmtrace_op_t);
+struct xen_domctl_set_llc_colors {
+ /* IN LLC coloring parameters */
+ uint32_t num_llc_colors;
+ uint32_t pad;
+ XEN_GUEST_HANDLE_64(uint32) llc_colors;
+};
+
struct xen_domctl {
uint32_t cmd;
#define XEN_DOMCTL_createdomain 1
@@ -1277,6 +1284,7 @@ struct xen_domctl {
#define XEN_DOMCTL_vmtrace_op 84
#define XEN_DOMCTL_get_paging_mempool_size 85
#define XEN_DOMCTL_set_paging_mempool_size 86
+#define XEN_DOMCTL_set_llc_colors 87
#define XEN_DOMCTL_gdbsx_guestmemio 1000
#define XEN_DOMCTL_gdbsx_pausevcpu 1001
#define XEN_DOMCTL_gdbsx_unpausevcpu 1002
@@ -1339,6 +1347,7 @@ struct xen_domctl {
struct xen_domctl_vuart_op vuart_op;
struct xen_domctl_vmtrace_op vmtrace_op;
struct xen_domctl_paging_mempool paging_mempool;
+ struct xen_domctl_set_llc_colors set_llc_colors;
uint8_t pad[128];
} u;
};
diff --git a/xen/include/xen/llc-coloring.h b/xen/include/xen/llc-coloring.h
index ee82932266..b3801fca00 100644
--- a/xen/include/xen/llc-coloring.h
+++ b/xen/include/xen/llc-coloring.h
@@ -29,6 +29,8 @@ static inline void domain_llc_coloring_free(struct domain *d) {}
unsigned int get_llc_way_size(void);
void arch_llc_coloring_init(void);
int dom0_set_llc_colors(struct domain *d);
+int domain_set_llc_colors(struct domain *d,
+ const struct xen_domctl_set_llc_colors *config);
#endif /* __COLORING_H__ */
--
2.34.1
next prev parent reply other threads:[~2024-05-02 16:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 16:55 [PATCH v8 00/13] Arm cache coloring Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 01/13] xen/common: add cache coloring common code Carlo Nonato
2024-05-06 11:54 ` Jan Beulich
2024-05-06 15:53 ` Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 02/13] xen/arm: add initial support for LLC coloring on arm64 Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 03/13] xen/arm: permit non direct-mapped Dom0 construction Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 04/13] xen/arm: add Dom0 cache coloring support Carlo Nonato
2024-05-06 12:01 ` Jan Beulich
2024-05-06 15:53 ` Carlo Nonato
2024-05-14 7:02 ` Jan Beulich
2024-05-02 16:55 ` Carlo Nonato [this message]
2024-05-06 12:05 ` [PATCH v8 05/13] xen: extend domctl interface for cache coloring Jan Beulich
2024-05-02 16:55 ` [PATCH v8 06/13] tools: add support for cache coloring configuration Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 07/13] xen/arm: add support for cache coloring configuration via device-tree Carlo Nonato
2024-05-06 12:11 ` Jan Beulich
2024-05-02 16:55 ` [PATCH v8 08/13] xen/page_alloc: introduce preserved page flags macro Carlo Nonato
2024-05-06 12:22 ` Jan Beulich
2024-05-06 15:54 ` Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 09/13] xen: add cache coloring allocator for domains Carlo Nonato
2024-05-06 12:46 ` Jan Beulich
2024-05-02 16:55 ` [PATCH v8 10/13] xen/arm: use domain memory to allocate p2m page tables Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 11/13] xen/arm: add Xen cache colors command line parameter Carlo Nonato
2024-05-06 13:24 ` Jan Beulich
2024-05-02 16:55 ` [PATCH v8 12/13] xen/arm: make consider_modules() available for xen relocation Carlo Nonato
2024-05-02 16:55 ` [PATCH v8 13/13] xen/arm: add cache coloring support for Xen Carlo Nonato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502165533.319988-6-carlo.nonato@minervasys.tech \
--to=carlo.nonato@minervasys.tech \
--cc=andrea.bastoni@minervasys.tech \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=marco.solieri@minervasys.tech \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).