From: Srujana Challa <schalla@marvell.com>
To: Jonah Palmer <jonah.palmer@oracle.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "mst@redhat.com" <mst@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"eperezma@redhat.com" <eperezma@redhat.com>,
"si-wei.liu@oracle.com" <si-wei.liu@oracle.com>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"raphael@enfabrica.net" <raphael@enfabrica.net>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"hreitz@redhat.com" <hreitz@redhat.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
"farman@linux.ibm.com" <farman@linux.ibm.com>,
"thuth@redhat.com" <thuth@redhat.com>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"david@redhat.com" <david@redhat.com>,
"iii@linux.ibm.com" <iii@linux.ibm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"fam@euphon.net" <fam@euphon.net>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"qemu-s390x@nongnu.org" <qemu-s390x@nongnu.org>,
"leiyang@redhat.com" <leiyang@redhat.com>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
"dtatulea@nvidia.com" <dtatulea@nvidia.com>,
"virtio-fs@lists.linux.dev" <virtio-fs@lists.linux.dev>
Subject: RE: [EXTERNAL] [PATCH v3 for 9.1 5/6] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits
Date: Mon, 18 Mar 2024 17:36:56 +0000 [thread overview]
Message-ID: <DS0PR18MB53681506B2D1472731345484A02D2@DS0PR18MB5368.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240315165557.26942-6-jonah.palmer@oracle.com>
> Subject: [EXTERNAL] [PATCH v3 for 9.1 5/6] vhost/vhost-user: Add
> VIRTIO_F_NOTIFICATION_DATA to vhost feature bits
>
> Prioritize security for external emails: Confirm sender and content safety
> before clicking links or opening attachments
>
> ----------------------------------------------------------------------
> Add support for the VIRTIO_F_NOTIFICATION_DATA feature across a variety of
> vhost devices.
>
> The inclusion of VIRTIO_F_NOTIFICATION_DATA in the feature bits arrays for
> these devices ensures that the backend is capable of offering and providing
> support for this feature, and that it can be disabled if the backend does not
> support it.
>
> Tested-by: Lei Yang <leiyang@redhat.com>
> Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
> ---
Acked-by: Srujana Challa <schalla@marvell.com>
> hw/block/vhost-user-blk.c | 1 +
> hw/net/vhost_net.c | 2 ++
> hw/scsi/vhost-scsi.c | 1 +
> hw/scsi/vhost-user-scsi.c | 1 +
> hw/virtio/vhost-user-fs.c | 2 +-
> hw/virtio/vhost-user-vsock.c | 1 +
> net/vhost-vdpa.c | 1 +
> 7 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index
> 6a856ad51a..983c0657da 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -51,6 +51,7 @@ static const int user_feature_bits[] = {
> VIRTIO_F_RING_PACKED,
> VIRTIO_F_IOMMU_PLATFORM,
> VIRTIO_F_RING_RESET,
> + VIRTIO_F_NOTIFICATION_DATA,
> VHOST_INVALID_FEATURE_BIT
> };
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index
> e8e1661646..bb1f975b39 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -48,6 +48,7 @@ static const int kernel_feature_bits[] = {
> VIRTIO_F_IOMMU_PLATFORM,
> VIRTIO_F_RING_PACKED,
> VIRTIO_F_RING_RESET,
> + VIRTIO_F_NOTIFICATION_DATA,
> VIRTIO_NET_F_HASH_REPORT,
> VHOST_INVALID_FEATURE_BIT
> };
> @@ -55,6 +56,7 @@ static const int kernel_feature_bits[] = {
> /* Features supported by others. */
> static const int user_feature_bits[] = {
> VIRTIO_F_NOTIFY_ON_EMPTY,
> + VIRTIO_F_NOTIFICATION_DATA,
> VIRTIO_RING_F_INDIRECT_DESC,
> VIRTIO_RING_F_EVENT_IDX,
>
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index
> ae26bc19a4..3d5fe0994d 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -38,6 +38,7 @@ static const int kernel_feature_bits[] = {
> VIRTIO_RING_F_EVENT_IDX,
> VIRTIO_SCSI_F_HOTPLUG,
> VIRTIO_F_RING_RESET,
> + VIRTIO_F_NOTIFICATION_DATA,
> VHOST_INVALID_FEATURE_BIT
> };
>
> diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c index
> a63b1f4948..0b050805a8 100644
> --- a/hw/scsi/vhost-user-scsi.c
> +++ b/hw/scsi/vhost-user-scsi.c
> @@ -36,6 +36,7 @@ static const int user_feature_bits[] = {
> VIRTIO_RING_F_EVENT_IDX,
> VIRTIO_SCSI_F_HOTPLUG,
> VIRTIO_F_RING_RESET,
> + VIRTIO_F_NOTIFICATION_DATA,
> VHOST_INVALID_FEATURE_BIT
> };
>
> diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c index
> cca2cd41be..ae48cc1c96 100644
> --- a/hw/virtio/vhost-user-fs.c
> +++ b/hw/virtio/vhost-user-fs.c
> @@ -33,7 +33,7 @@ static const int user_feature_bits[] = {
> VIRTIO_F_RING_PACKED,
> VIRTIO_F_IOMMU_PLATFORM,
> VIRTIO_F_RING_RESET,
> -
> + VIRTIO_F_NOTIFICATION_DATA,
> VHOST_INVALID_FEATURE_BIT
> };
>
> diff --git a/hw/virtio/vhost-user-vsock.c b/hw/virtio/vhost-user-vsock.c index
> 9431b9792c..802b44a07d 100644
> --- a/hw/virtio/vhost-user-vsock.c
> +++ b/hw/virtio/vhost-user-vsock.c
> @@ -21,6 +21,7 @@ static const int user_feature_bits[] = {
> VIRTIO_RING_F_INDIRECT_DESC,
> VIRTIO_RING_F_EVENT_IDX,
> VIRTIO_F_NOTIFY_ON_EMPTY,
> + VIRTIO_F_NOTIFICATION_DATA,
> VHOST_INVALID_FEATURE_BIT
> };
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index
> 2a9ddb4552..5583ce5279 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -61,6 +61,7 @@ const int vdpa_feature_bits[] = {
> VIRTIO_F_RING_PACKED,
> VIRTIO_F_RING_RESET,
> VIRTIO_F_VERSION_1,
> + VIRTIO_F_NOTIFICATION_DATA,
> VIRTIO_NET_F_CSUM,
> VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
> VIRTIO_NET_F_CTRL_MAC_ADDR,
> --
> 2.39.3
next prev parent reply other threads:[~2024-03-18 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 16:55 [PATCH v3 for 9.1 0/6] virtio,vhost: Add VIRTIO_F_NOTIFICATION_DATA support Jonah Palmer
2024-03-15 16:55 ` [PATCH v3 for 9.1 1/6] virtio/virtio-pci: Handle extra notification data Jonah Palmer
2024-03-15 18:31 ` Eugenio Perez Martin
2024-03-15 16:55 ` [PATCH v3 for 9.1 2/6] virtio: Prevent creation of device using notification-data with ioeventfd Jonah Palmer
2024-03-15 16:55 ` [PATCH v3 for 9.1 3/6] virtio-mmio: Handle extra notification data Jonah Palmer
2024-03-15 16:55 ` [PATCH v3 for 9.1 4/6] virtio-ccw: " Jonah Palmer
2024-03-15 16:55 ` [PATCH v3 for 9.1 5/6] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits Jonah Palmer
2024-03-18 17:36 ` Srujana Challa [this message]
2024-03-15 16:55 ` [PATCH v3 for 9.1 6/6] virtio: Add VIRTIO_F_NOTIFICATION_DATA property definition Jonah Palmer
2024-03-16 15:45 ` [PATCH v3 for 9.1 0/6] virtio, vhost: Add VIRTIO_F_NOTIFICATION_DATA support Jiri Pirko
2024-03-18 11:22 ` Jonah Palmer
2024-03-18 11:55 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR18MB53681506B2D1472731345484A02D2@DS0PR18MB5368.namprd18.prod.outlook.com \
--to=schalla@marvell.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=iii@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=jerinj@marvell.com \
--cc=jonah.palmer@oracle.com \
--cc=kwolf@redhat.com \
--cc=leiyang@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=raphael@enfabrica.net \
--cc=richard.henderson@linaro.org \
--cc=si-wei.liu@oracle.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vattunuru@marvell.com \
--cc=virtio-fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).