From: Jonah Palmer <jonah.palmer@oracle.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, jasowang@redhat.com, eperezma@redhat.com,
si-wei.liu@oracle.com, boris.ostrovsky@oracle.com,
jonah.palmer@oracle.com, raphael@enfabrica.net, kwolf@redhat.com,
hreitz@redhat.com, pasic@linux.ibm.com,
borntraeger@linux.ibm.com, farman@linux.ibm.com,
thuth@redhat.com, richard.henderson@linaro.org, david@redhat.com,
iii@linux.ibm.com, cohuck@redhat.com, pbonzini@redhat.com,
fam@euphon.net, stefanha@redhat.com, qemu-block@nongnu.org,
qemu-s390x@nongnu.org, leiyang@redhat.com, schalla@marvell.com,
vattunuru@marvell.com, jerinj@marvell.com, dtatulea@nvidia.com,
virtio-fs@lists.linux.dev
Subject: [PATCH v3 for 9.1 0/6] virtio,vhost: Add VIRTIO_F_NOTIFICATION_DATA support
Date: Fri, 15 Mar 2024 12:55:51 -0400 [thread overview]
Message-ID: <20240315165557.26942-1-jonah.palmer@oracle.com> (raw)
The goal of these patches are to add support to a variety of virtio and
vhost devices for the VIRTIO_F_NOTIFICATION_DATA transport feature. This
feature indicates that a driver will pass extra data (instead of just a
virtqueue's index) when notifying the corresponding device.
The data passed in by the driver when this feature is enabled varies in
format depending on if the device is using a split or packed virtqueue
layout:
Split VQ
- Upper 16 bits: shadow_avail_idx
- Lower 16 bits: virtqueue index
Packed VQ
- Upper 16 bits: 1-bit wrap counter & 15-bit shadow_avail_idx
- Lower 16 bits: virtqueue index
Also, due to the limitations of ioeventfd not being able to carry the
extra provided by the driver, having both VIRTIO_F_NOTIFICATION_DATA
feature and ioeventfd enabled is a functional mismatch. The user must
explicitly disable ioeventfd for the device in the Qemu arguments when
using this feature, else the device will fail to complete realization.
For example, a device must explicitly enable notification_data as well
as disable ioeventfd:
-device virtio-scsi-pci,...,ioeventfd=off,notification_data=on
A significant aspect of this effort has been to maintain compatibility
across different backends. As such, the feature is offered by backend
devices only when supported, with fallback mechanisms where backend
support is absent.
v3: Validate VQ idx via. virtio_queue_get_num() (pci, mmio, ccw)
Rename virtio_queue_set_shadow_avail_data
Only pass in upper 16 bits of 32-bit extra data (was redundant)
Make notification compatibility check function static
Drop tags on patches 1/6, 3/6, and 4/6
v2: Don't disable ioeventfd by default, user must disable it
Drop tags on patch 2/6
Jonah Palmer (6):
virtio/virtio-pci: Handle extra notification data
virtio: Prevent creation of device using notification-data with ioeventfd
virtio-mmio: Handle extra notification data
virtio-ccw: Handle extra notification data
vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits
virtio: Add VIRTIO_F_NOTIFICATION_DATA property definition
hw/block/vhost-user-blk.c | 1 +
hw/net/vhost_net.c | 2 ++
hw/s390x/s390-virtio-ccw.c | 17 +++++++++++----
hw/scsi/vhost-scsi.c | 1 +
hw/scsi/vhost-user-scsi.c | 1 +
hw/virtio/vhost-user-fs.c | 2 +-
hw/virtio/vhost-user-vsock.c | 1 +
hw/virtio/virtio-mmio.c | 10 +++++++--
hw/virtio/virtio-pci.c | 11 +++++++---
hw/virtio/virtio.c | 40 ++++++++++++++++++++++++++++++++++++
include/hw/virtio/virtio.h | 6 +++++-
net/vhost-vdpa.c | 1 +
12 files changed, 82 insertions(+), 11 deletions(-)
--
2.39.3
next reply other threads:[~2024-03-15 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 16:55 Jonah Palmer [this message]
2024-03-15 16:55 ` [PATCH v3 for 9.1 1/6] virtio/virtio-pci: Handle extra notification data Jonah Palmer
2024-03-15 18:31 ` Eugenio Perez Martin
2024-03-15 16:55 ` [PATCH v3 for 9.1 2/6] virtio: Prevent creation of device using notification-data with ioeventfd Jonah Palmer
2024-03-15 16:55 ` [PATCH v3 for 9.1 3/6] virtio-mmio: Handle extra notification data Jonah Palmer
2024-03-15 16:55 ` [PATCH v3 for 9.1 4/6] virtio-ccw: " Jonah Palmer
2024-03-15 16:55 ` [PATCH v3 for 9.1 5/6] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits Jonah Palmer
2024-03-18 17:36 ` [EXTERNAL] " Srujana Challa
2024-03-15 16:55 ` [PATCH v3 for 9.1 6/6] virtio: Add VIRTIO_F_NOTIFICATION_DATA property definition Jonah Palmer
2024-03-16 15:45 ` [PATCH v3 for 9.1 0/6] virtio, vhost: Add VIRTIO_F_NOTIFICATION_DATA support Jiri Pirko
2024-03-18 11:22 ` Jonah Palmer
2024-03-18 11:55 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315165557.26942-1-jonah.palmer@oracle.com \
--to=jonah.palmer@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=iii@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=jerinj@marvell.com \
--cc=kwolf@redhat.com \
--cc=leiyang@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=raphael@enfabrica.net \
--cc=richard.henderson@linaro.org \
--cc=schalla@marvell.com \
--cc=si-wei.liu@oracle.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vattunuru@marvell.com \
--cc=virtio-fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).