From: zhanchengbin <zhanchengbin1@huawei.com>
To: Karel Zak <kzak@redhat.com>
Cc: <util-linux@vger.kernel.org>, Lukas Czerner <lczerner@redhat.com>,
<djwong@kernel.org>, <liuzhiqiang26@huawei.com>,
linfeilong <linfeilong@huawei.com>
Subject: [PATCH] disk-utils/fsck.c: Processes may kill other processes.
Date: Mon, 10 Oct 2022 17:41:17 +0800 [thread overview]
Message-ID: <f53df0ef-8474-6b0c-1a36-cf3e1282106c@huawei.com> (raw)
A error in disk-utils/fsck.c, if run the fsck -N command, processes
don't execute, just show what would be done. However, the pid whose
value is -1 is added to the instance_list list in the execute
function,if the kill_all function is called later, kill(-1, signum)
is executed, Signals are sent to all processes except the number one
process and itself. Other processes will be killed if they use the
default signal processing function.
Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
disk-utils/fsck.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
index 505952c81..800d3ce08 100644
--- a/disk-utils/fsck.c
+++ b/disk-utils/fsck.c
@@ -730,6 +730,8 @@ static int kill_all(int signum)
for (inst = instance_list; inst; inst = inst->next) {
if (inst->flags & FLAG_DONE)
continue;
+ if (inst->pid <= 0)
+ continue;
kill(inst->pid, signum);
n++;
}
--
2.27.0
next reply other threads:[~2022-10-10 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 9:41 zhanchengbin [this message]
2022-10-10 13:06 ` [PATCH] disk-utils/fsck.c: Processes may kill other processes Lukas Czerner
2022-10-17 7:14 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f53df0ef-8474-6b0c-1a36-cf3e1282106c@huawei.com \
--to=zhanchengbin1@huawei.com \
--cc=djwong@kernel.org \
--cc=kzak@redhat.com \
--cc=lczerner@redhat.com \
--cc=linfeilong@huawei.com \
--cc=liuzhiqiang26@huawei.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).