From: Karel Zak <kzak@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: zhanchengbin <zhanchengbin1@huawei.com>,
util-linux@vger.kernel.org, djwong@kernel.org,
liuzhiqiang26@huawei.com, linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] disk-utils/fsck.c: Processes may kill other processes.
Date: Mon, 17 Oct 2022 09:14:09 +0200 [thread overview]
Message-ID: <20221017071409.uhagyb62gobjmzec@ws.net.home> (raw)
In-Reply-To: <20221010130651.qnwjg36v6n3h6zfg@fedora>
On Mon, Oct 10, 2022 at 03:06:51PM +0200, Lukas Czerner wrote:
> On Mon, Oct 10, 2022 at 05:41:17PM +0800, zhanchengbin wrote:
> > A error in disk-utils/fsck.c, if run the fsck -N command, processes
> > don't execute, just show what would be done. However, the pid whose
> > value is -1 is added to the instance_list list in the execute
> > function,if the kill_all function is called later, kill(-1, signum)
> > is executed, Signals are sent to all processes except the number one
> > process and itself. Other processes will be killed if they use the
> > default signal processing function.
>
> Looks good thanks.
>
> >
> > Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ^^^
> Here as well, please remove my Sob and you can add
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Applied, thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2022-10-17 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 9:41 [PATCH] disk-utils/fsck.c: Processes may kill other processes zhanchengbin
2022-10-10 13:06 ` Lukas Czerner
2022-10-17 7:14 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017071409.uhagyb62gobjmzec@ws.net.home \
--to=kzak@redhat.com \
--cc=djwong@kernel.org \
--cc=lczerner@redhat.com \
--cc=linfeilong@huawei.com \
--cc=liuzhiqiang26@huawei.com \
--cc=util-linux@vger.kernel.org \
--cc=zhanchengbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).