From: Quentin Schulz <quentin.schulz@cherry.de>
To: Anand Moon <anand@edgeble.ai>, Tom Rini <trini@konsulko.com>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>
Cc: Jagan Teki <jagan@edgeble.ai>, u-boot@lists.denx.de
Subject: Re: [PATCH v1 5/9] arm: rockchip: Enable display cpuinfo to be build with SPL_BUILD
Date: Thu, 16 May 2024 15:45:28 +0200 [thread overview]
Message-ID: <ab5ca03b-021c-46c3-90b6-079fe6b01aa8@cherry.de> (raw)
In-Reply-To: <20240516090031.2373-6-anand@edgeble.ai>
Hi Anand,
On 5/16/24 10:59 AM, Anand Moon wrote:
> Changes help enable CONFIG_DISPLAY_CPUINFO to build with SPL_BUILD for
> SoC RK356x and RK3588.
> > Cc: Jagan Teki <jagan@edgeble.ai>
> Signed-off-by: Anand Moon <anand@edgeble.ai>
> ---
> arch/arm/mach-rockchip/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/Makefile b/arch/arm/mach-rockchip/Makefile
> index c07bdaee4c..6722e7c9ea 100644
> --- a/arch/arm/mach-rockchip/Makefile
> +++ b/arch/arm/mach-rockchip/Makefile
> @@ -25,7 +25,7 @@ obj-y += boot_mode.o
> obj-$(CONFIG_ROCKCHIP_COMMON_BOARD) += board.o
> endif
>
> -ifeq ($(CONFIG_TPL_BUILD),)
> +ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TPL_BUILD),)
If I'm not mistaken, this is a way for disabling building cpu-info.o if
either in TPL or SPL build mode (therefore only compiling for proper
build mode).
I think it'd make more sense to convert CONFIG_DISPLAY_CPUINFO into
three symbols, e.g. CONFIG_TPL_DISPLAY_CPUINFO, CONFIG_SPL_DISPLAY_INFO
and then use
"""
obj-$(CONFIG_$(TPL_SPL_)DISPLAY_CPUINFO) += cpu-info.o
"""
Also... considering the mail I sent to your first patch in this patch
series, if we migrate to using sysreset driver to print the reset
reason, we wouldn't need this file anymore so we could remove it and not
have to care about this.
Cheers,
Quentin
next prev parent reply other threads:[~2024-05-16 13:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240516090031.2373-1-anand@edgeble.ai>
2024-05-16 8:59 ` [PATCH v1 1/9] rockchip: RK3328: Read the reset cause from clock reset unit for RK3328 SoC Anand Moon
2024-05-16 13:39 ` Quentin Schulz
2024-05-16 8:59 ` [PATCH v1 2/9] rockchip: RK3328: Enable display cpuinfo support on all boards Anand Moon
2024-05-16 8:59 ` [PATCH v1 3/9] rockchip: RK3399: Read the reset cause from clock reset unit for RK3399 SoC Anand Moon
2024-05-16 8:59 ` [PATCH v1 4/9] rockchip: RK3399: Enable display cpuinfo support on all boards Anand Moon
2024-05-16 8:59 ` [PATCH v1 5/9] arm: rockchip: Enable display cpuinfo to be build with SPL_BUILD Anand Moon
2024-05-16 13:45 ` Quentin Schulz [this message]
2024-05-16 14:03 ` Jonas Karlman
2024-05-16 8:59 ` [PATCH v1 6/9] rockchip: RK3568: Read the reset cause from clock reset unit for RK356x SoC Anand Moon
2024-05-16 14:17 ` Jonas Karlman
2024-05-17 7:45 ` Anand Moon
2024-05-24 8:48 ` Anand Moon
2024-05-16 8:59 ` [PATCH v1 7/9] rockchip: RK356x: Enable display cpuinfo support on all boards Anand Moon
2024-05-16 8:59 ` [PATCH v1 8/9] rockchip: RK3588: Read the reset cause from clock reset unit for RK3588 SoC Anand Moon
2024-05-16 8:59 ` [PATCH v1 9/9] rockchip: RK3588: Enable display cpuinfo support on all boards Anand Moon
2024-05-16 9:21 ` Quentin Schulz
2024-05-16 10:12 ` Anand Moon
2024-05-16 10:43 ` Quentin Schulz
2024-05-16 11:51 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5ca03b-021c-46c3-90b6-079fe6b01aa8@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=anand@edgeble.ai \
--cc=jagan@edgeble.ai \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).