From: Andre Przywara <andre.przywara@arm.com>
To: Michael Walle <mwalle@kernel.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>, Tom Rini <trini@konsulko.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
Samuel Holland <samuel@sholland.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] net: sun8i_emac: add support for the V3s
Date: Tue, 14 May 2024 11:27:53 +0100 [thread overview]
Message-ID: <20240514112753.0d30484d@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20240513205609.1872861-3-mwalle@kernel.org>
On Mon, 13 May 2024 22:56:09 +0200
Michael Walle <mwalle@kernel.org> wrote:
Hi,
> Add the compatible string for the emac found on the V3s SoC. The SoC
> only supports the internal PHY. There are no (R)MII signals on any pins.
>
> Signed-off-by: Michael Walle <mwalle@kernel.org>
Nice, that seems indeed all we need for that SoC.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> drivers/net/sun8i_emac.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
> index 8bff4fe9a9e..94bcd40acb8 100644
> --- a/drivers/net/sun8i_emac.c
> +++ b/drivers/net/sun8i_emac.c
> @@ -893,6 +893,11 @@ static const struct emac_variant emac_variant_r40 = {
> .syscon_offset = 0x164,
> };
>
> +static const struct emac_variant emac_variant_v3s = {
> + .syscon_offset = 0x30,
> + .soc_has_internal_phy = true,
> +};
> +
> static const struct emac_variant emac_variant_a64 = {
> .syscon_offset = 0x30,
> .support_rmii = true,
> @@ -910,6 +915,8 @@ static const struct udevice_id sun8i_emac_eth_ids[] = {
> .data = (ulong)&emac_variant_h3 },
> { .compatible = "allwinner,sun8i-r40-gmac",
> .data = (ulong)&emac_variant_r40 },
> + { .compatible = "allwinner,sun8i-v3s-emac",
> + .data = (ulong)&emac_variant_v3s },
> { .compatible = "allwinner,sun50i-a64-emac",
> .data = (ulong)&emac_variant_a64 },
> { .compatible = "allwinner,sun50i-h6-emac",
prev parent reply other threads:[~2024-05-14 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 20:56 [PATCH 0/2] sunxi: v3s: add network support Michael Walle
2024-05-13 20:56 ` [PATCH 1/2] clk: sunxi: add EMAC and EPHY clocks and resets for the V3s SoC Michael Walle
2024-05-14 10:16 ` Andre Przywara
2024-05-13 20:56 ` [PATCH 2/2] net: sun8i_emac: add support for the V3s Michael Walle
2024-05-14 10:27 ` Andre Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514112753.0d30484d@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=joe.hershberger@ni.com \
--cc=lukma@denx.de \
--cc=mwalle@kernel.org \
--cc=rfried.dev@gmail.com \
--cc=samuel@sholland.org \
--cc=seanga2@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).