From: Sean Anderson <seanga2@gmail.com>
To: Igor Prusov <ivprusov@sberdevices.ru>,
u-boot@lists.denx.de, Michal Simek <michal.simek@amd.com>,
Daniel Schwierzeck <daniel.schwierzeck@gmail.com>,
Lukasz Majewski <lukma@denx.de>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Stefan Roese <sr@denx.de>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>
Cc: prusovigor@gmail.com, kernel@sberdevices.ru,
Aspeed BMC SW team <BMC-SW@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>,
u-boot-amlogic@groups.io,
uboot-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v7 5/8] clk: Add dump operation to clk_ops
Date: Fri, 15 Dec 2023 15:51:12 -0500 [thread overview]
Message-ID: <eea5dfe6-ca73-adb9-3f46-fe4ef0d8b64b@gmail.com> (raw)
In-Reply-To: <20231109105516.24892-6-ivprusov@sberdevices.ru>
On 11/9/23 05:55, Igor Prusov wrote:
> This adds dump function to struct clk_ops which should replace
> soc_clk_dump. It allows clock drivers to provide custom dump
> implementation without overriding generic CCF dump function.
>
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Tested-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>
> Signed-off-by: Igor Prusov <ivprusov@sberdevices.ru>
> ---
> include/clk-uclass.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/clk-uclass.h b/include/clk-uclass.h
> index a22f1a5d84..f10dd213ff 100644
> --- a/include/clk-uclass.h
> +++ b/include/clk-uclass.h
> @@ -25,6 +25,7 @@ struct ofnode_phandle_args;
> * @set_parent: Set current clock parent
> * @enable: Enable a clock.
> * @disable: Disable a clock.
> + * @dump: Print clock information.
> *
> * The individual methods are described more fully below.
> */
> @@ -39,6 +40,9 @@ struct clk_ops {
> int (*set_parent)(struct clk *clk, struct clk *parent);
> int (*enable)(struct clk *clk);
> int (*disable)(struct clk *clk);
> +#if IS_ENABLED(CONFIG_CMD_CLK)
> + void (*dump)(struct udevice *dev);
> +#endif
> };
>
> #if 0 /* For documentation only */
> @@ -135,6 +139,15 @@ int enable(struct clk *clk);
> * Return: zero on success, or -ve error code.
> */
> int disable(struct clk *clk);
> +
> +/**
> + * dump() - Print clock information.
> + * @clk: The clock device to dump.
The correct member here is @dev. I fixed this when applying.
--Sean
> + * If present, this function is called by "clk dump" command for each
> + * bound device.
> + */
> +void dump(struct udevice *dev);
> #endif
>
> #endif
next prev parent reply other threads:[~2023-12-18 8:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 10:55 [PATCH v7 0/8] clk: Switch from soc_clk_dump to clk_ops function Igor Prusov
2023-11-09 10:55 ` [PATCH v7 1/8] clk: zynq: Move soc_clk_dump to Zynq clock driver Igor Prusov
2023-11-09 10:55 ` [PATCH v7 2/8] clk: ast2600: Move soc_clk_dump function Igor Prusov
2023-11-09 10:55 ` [PATCH v7 3/8] clk: k210: " Igor Prusov
2023-11-09 10:55 ` [PATCH v7 4/8] clk: amlogic: Move driver and ops structs Igor Prusov
2023-11-09 10:55 ` [PATCH v7 5/8] clk: Add dump operation to clk_ops Igor Prusov
2023-12-15 20:51 ` Sean Anderson [this message]
2023-11-09 10:55 ` [PATCH v7 6/8] cmd: clk: Use dump function from clk_ops Igor Prusov
2023-11-09 10:55 ` [PATCH v7 7/8] clk: treewide: switch to clock dump " Igor Prusov
2023-11-09 10:55 ` [PATCH v7 8/8] cmd: clk: Make soc_clk_dump static Igor Prusov
2023-12-12 14:03 ` [PATCH v7 0/8] clk: Switch from soc_clk_dump to clk_ops function Neil Armstrong
2023-12-12 14:11 ` Sean Anderson
2023-12-15 20:48 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eea5dfe6-ca73-adb9-3f46-fe4ef0d8b64b@gmail.com \
--to=seanga2@gmail.com \
--cc=BMC-SW@aspeedtech.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=daniel.schwierzeck@gmail.com \
--cc=ivprusov@sberdevices.ru \
--cc=joel@jms.id.au \
--cc=kernel@sberdevices.ru \
--cc=lukma@denx.de \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=prusovigor@gmail.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sr@denx.de \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).