From: Igor Prusov <ivprusov@sberdevices.ru>
To: <u-boot@lists.denx.de>, Michal Simek <michal.simek@amd.com>,
Daniel Schwierzeck <daniel.schwierzeck@gmail.com>,
Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Stefan Roese <sr@denx.de>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>
Cc: <prusovigor@gmail.com>, <kernel@sberdevices.ru>,
Igor Prusov <ivprusov@sberdevices.ru>,
Aspeed BMC SW team <BMC-SW@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>, <u-boot-amlogic@groups.io>,
<uboot-stm32@st-md-mailman.stormreply.com>
Subject: [PATCH v7 0/8] clk: Switch from soc_clk_dump to clk_ops function
Date: Thu, 9 Nov 2023 13:55:08 +0300 [thread overview]
Message-ID: <20231109105516.24892-1-ivprusov@sberdevices.ru> (raw)
Currently clock providers may override default implementation of
soc_clk_dump function to replace clk dump command output. This causes
confusing behaviour when u-boot is built with one of such drivers
enabled but still has clocks defined using CCF. For example, enabling
CMD_CLK and using clk dump on sandbox target will not show CCF clocks
because k210 driver overrides common soc_clk_dump.
Changelog:
v1 -> v2:
- Add missing static to dump functions
v2 -> v3:
- Make soc_clk_dump in cmd/clk.c static instead of removing __weak
v3 -> v4:
- Rebase and refactor dump for new Amlogic A1 clock controller driver
v4 -> v5:
- Add docs for dump() function in clk_ops
- Print driver and device names before calling corresponding dump()
v5 -> v6:
- dump() return type changed to void
- meson_clk_dump() and helper functions moved under CONFIG_CMD_CLK to
fix unused-function diagnostic
v6 -> v7:
- fix return type of k210_clk_dump()
- fix clk_ops dump() docs since it returns void now
Igor Prusov (8):
clk: zynq: Move soc_clk_dump to Zynq clock driver
clk: ast2600: Move soc_clk_dump function
clk: k210: Move soc_clk_dump function
clk: amlogic: Move driver and ops structs
clk: Add dump operation to clk_ops
cmd: clk: Use dump function from clk_ops
clk: treewide: switch to clock dump from clk_ops
cmd: clk: Make soc_clk_dump static
arch/arm/mach-zynq/clk.c | 57 --------------
arch/mips/mach-pic32/cpu.c | 23 ------
cmd/clk.c | 13 +++-
drivers/clk/aspeed/clk_ast2600.c | 83 ++++++++++----------
drivers/clk/clk_k210.c | 104 ++++++++++++-------------
drivers/clk/clk_pic32.c | 37 +++++++++
drivers/clk/clk_versal.c | 9 ++-
drivers/clk/clk_zynq.c | 52 +++++++++++++
drivers/clk/clk_zynqmp.c | 22 +++---
drivers/clk/imx/clk-imx8.c | 13 +---
drivers/clk/meson/a1.c | 58 ++++++--------
drivers/clk/mvebu/armada-37xx-periph.c | 20 +++--
drivers/clk/stm32/clk-stm32mp1.c | 31 ++------
include/clk-uclass.h | 13 ++++
include/clk.h | 2 -
15 files changed, 269 insertions(+), 268 deletions(-)
--
2.34.1
next reply other threads:[~2023-11-09 10:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 10:55 Igor Prusov [this message]
2023-11-09 10:55 ` [PATCH v7 1/8] clk: zynq: Move soc_clk_dump to Zynq clock driver Igor Prusov
2023-11-09 10:55 ` [PATCH v7 2/8] clk: ast2600: Move soc_clk_dump function Igor Prusov
2023-11-09 10:55 ` [PATCH v7 3/8] clk: k210: " Igor Prusov
2023-11-09 10:55 ` [PATCH v7 4/8] clk: amlogic: Move driver and ops structs Igor Prusov
2023-11-09 10:55 ` [PATCH v7 5/8] clk: Add dump operation to clk_ops Igor Prusov
2023-12-15 20:51 ` Sean Anderson
2023-11-09 10:55 ` [PATCH v7 6/8] cmd: clk: Use dump function from clk_ops Igor Prusov
2023-11-09 10:55 ` [PATCH v7 7/8] clk: treewide: switch to clock dump " Igor Prusov
2023-11-09 10:55 ` [PATCH v7 8/8] cmd: clk: Make soc_clk_dump static Igor Prusov
2023-12-12 14:03 ` [PATCH v7 0/8] clk: Switch from soc_clk_dump to clk_ops function Neil Armstrong
2023-12-12 14:11 ` Sean Anderson
2023-12-15 20:48 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109105516.24892-1-ivprusov@sberdevices.ru \
--to=ivprusov@sberdevices.ru \
--cc=BMC-SW@aspeedtech.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=daniel.schwierzeck@gmail.com \
--cc=joel@jms.id.au \
--cc=kernel@sberdevices.ru \
--cc=lukma@denx.de \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=prusovigor@gmail.com \
--cc=ryan_chen@aspeedtech.com \
--cc=seanga2@gmail.com \
--cc=sr@denx.de \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).