From: "Karel Balej" <balejk@matfyz.cz>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <regressions@lists.linux.dev>, <linux-pwm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [REGRESSION] PWM vibrator does not probe with v6.9-rc1
Date: Thu, 28 Mar 2024 17:27:03 +0100 [thread overview]
Message-ID: <D05IVTPYH35N.2CLDG6LSILRSN@matfyz.cz> (raw)
Uwe,
I am working on bringing the mainline Linux to my old smartphone. Most
of the changes are not yet in-tree.
The phone has a PWM vibrator for which the corresponding input driver
(pwm-vibrator) is used. The driver used for the PWM is pwm-pxa (or
pxa25x-pwm).
The DT nodes look like this
[...]
pwm: pwm@1ac00 {
compatible = "marvell,pxa250-pwm";
reg = <0x1ac00 0x10>;
#pwm-cells = <1>;
clocks = <&apbc PXA1908_CLK_PWM3>;
};
[...]
vibrator {
compatible = "pwm-vibrator";
pwm-names = "enable";
pwms = <&pwm 100000>;
enable-gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&vibrator_pins>;
};
[...]
The vibrator worked fine with v6.8-rc6 but after I rebased to v6.9-rc1,
it no longer probes printing
[ +0.000118] pwm-vibrator vibrator: failed to apply initial PWM state: -22
to dmesg.
I have bisected the problem to 40ade0c2e794 ("pwm: Let the of_xlate
callbacks accept references without period").
Looking at the commit and adjacent history, I don't believe this problem
is caused by this still being an out-of-tree DT, nonetheless, if it
proves to be the case, then I apologize for false alarm.
Would you please take a look?
Thank you and kind regards,
K. B.
#regzbot introduced: 40ade0c2e794
next reply other threads:[~2024-03-28 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 16:27 Karel Balej [this message]
2024-03-29 10:35 ` [PATCH] pwm: Fix setting period with #pwm-cells = <1> and of_pwm_single_xlate() Uwe Kleine-König
2024-03-29 11:21 ` Karel Balej
2024-03-29 13:24 ` Uwe Kleine-König
2024-03-29 14:09 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D05IVTPYH35N.2CLDG6LSILRSN@matfyz.cz \
--to=balejk@matfyz.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).