From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Sergio Lopez <slp@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Michael Roth <michael.roth@amd.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 4/6] hw/i386/x86: Don't leak "pc.bios" memory region
Date: Tue, 30 Apr 2024 17:31:05 +0200 [thread overview]
Message-ID: <bf952a4c-282d-4d4f-883e-8d97258e12c9@linaro.org> (raw)
In-Reply-To: <20240430150643.111976-5-shentey@gmail.com>
On 30/4/24 17:06, Bernhard Beschow wrote:
> Fix the leaking in x86_bios_rom_init() by adding a "bios" attribute to
> X86MachineState. Note that it is only used in the -bios case.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> include/hw/i386/x86.h | 1 +
> hw/i386/x86.c | 13 ++++++-------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h
> index 271ad50470..fb41263b9d 100644
> --- a/include/hw/i386/x86.h
> +++ b/include/hw/i386/x86.h
> @@ -52,6 +52,7 @@ struct X86MachineState {
> DeviceState *ioapic2;
> GMappedFile *initrd_mapped_file;
> HotplugHandler *acpi_dev;
> + MemoryRegion bios;
> MemoryRegion isa_bios;
Do you mind describing what is each in a small comment?
Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-04-30 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 15:06 [PATCH v2 0/6] This series changes the "isa-bios" MemoryRegion to be an alias rather than a Bernhard Beschow
2024-04-30 15:06 ` [PATCH v2 1/6] hw/i386/x86: Eliminate two if statements in x86_bios_rom_init() Bernhard Beschow
2024-04-30 15:06 ` [PATCH v2 2/6] hw/i386: Have x86_bios_rom_init() take X86MachineState rather than MachineState Bernhard Beschow
2024-04-30 15:36 ` Philippe Mathieu-Daudé
2024-04-30 15:06 ` [PATCH v2 3/6] hw/i386/x86: Don't leak "isa-bios" memory regions Bernhard Beschow
2024-04-30 15:29 ` Philippe Mathieu-Daudé
2024-04-30 15:06 ` [PATCH v2 4/6] hw/i386/x86: Don't leak "pc.bios" memory region Bernhard Beschow
2024-04-30 15:31 ` Philippe Mathieu-Daudé [this message]
2024-04-30 15:06 ` [PATCH v2 5/6] hw/i386/x86: Extract x86_isa_bios_init() from x86_bios_rom_init() Bernhard Beschow
2024-04-30 15:33 ` Philippe Mathieu-Daudé
2024-04-30 15:06 ` [PATCH v2 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region Bernhard Beschow
2024-04-30 15:39 ` Philippe Mathieu-Daudé
2024-05-08 8:17 ` Bernhard Beschow
2024-05-08 9:58 ` Philippe Mathieu-Daudé
2024-05-08 15:56 ` Paolo Bonzini
2024-05-08 14:53 ` [PATCH v2 0/6] This series changes the "isa-bios" MemoryRegion to be an alias rather than a Philippe Mathieu-Daudé
2024-05-08 18:00 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf952a4c-282d-4d4f-883e-8d97258e12c9@linaro.org \
--to=philmd@linaro.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).