From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Sergio Lopez" <slp@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Michael Roth" <michael.roth@amd.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v2 0/6] This series changes the "isa-bios" MemoryRegion to be an alias rather than a
Date: Tue, 30 Apr 2024 17:06:37 +0200 [thread overview]
Message-ID: <20240430150643.111976-1-shentey@gmail.com> (raw)
region which matches real hardware and which some real-world legacy bioses I'm
running rely on. Furthermore, aliasing in the isa-bios area is already the
current behavior in the bios (a.k.a. ROM) case, so this series consolidates
behavior.
For migration compatibility the aliasing is only performed on new versions of
the q34 and pc machine types.
v2:
* Don't leak bios memory regions (Phil)
* Add compat machinery (Michael)
Testing done:
* `make check` with qemu-system-x86_64 (QEMU 8.2.2) installed. All tests
including migration tests pass.
* `make check-avocado`
Best regards,
Bernhard
Bernhard Beschow (6):
hw/i386/x86: Eliminate two if statements in x86_bios_rom_init()
hw/i386: Have x86_bios_rom_init() take X86MachineState rather than
MachineState
hw/i386/x86: Don't leak "isa-bios" memory regions
hw/i386/x86: Don't leak "pc.bios" memory region
hw/i386/x86: Extract x86_isa_bios_init() from x86_bios_rom_init()
hw/i386/pc_sysfw: Alias rather than copy isa-bios region
include/hw/i386/pc.h | 1 +
include/hw/i386/x86.h | 7 ++++++-
hw/i386/microvm.c | 2 +-
hw/i386/pc.c | 1 +
hw/i386/pc_piix.c | 3 +++
hw/i386/pc_q35.c | 2 ++
hw/i386/pc_sysfw.c | 17 ++++++++++------
hw/i386/x86.c | 45 ++++++++++++++++++++++---------------------
8 files changed, 48 insertions(+), 30 deletions(-)
--
2.45.0
next reply other threads:[~2024-04-30 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 15:06 Bernhard Beschow [this message]
2024-04-30 15:06 ` [PATCH v2 1/6] hw/i386/x86: Eliminate two if statements in x86_bios_rom_init() Bernhard Beschow
2024-04-30 15:06 ` [PATCH v2 2/6] hw/i386: Have x86_bios_rom_init() take X86MachineState rather than MachineState Bernhard Beschow
2024-04-30 15:36 ` Philippe Mathieu-Daudé
2024-04-30 15:06 ` [PATCH v2 3/6] hw/i386/x86: Don't leak "isa-bios" memory regions Bernhard Beschow
2024-04-30 15:29 ` Philippe Mathieu-Daudé
2024-04-30 15:06 ` [PATCH v2 4/6] hw/i386/x86: Don't leak "pc.bios" memory region Bernhard Beschow
2024-04-30 15:31 ` Philippe Mathieu-Daudé
2024-04-30 15:06 ` [PATCH v2 5/6] hw/i386/x86: Extract x86_isa_bios_init() from x86_bios_rom_init() Bernhard Beschow
2024-04-30 15:33 ` Philippe Mathieu-Daudé
2024-04-30 15:06 ` [PATCH v2 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region Bernhard Beschow
2024-04-30 15:39 ` Philippe Mathieu-Daudé
2024-05-08 8:17 ` Bernhard Beschow
2024-05-08 9:58 ` Philippe Mathieu-Daudé
2024-05-08 15:56 ` Paolo Bonzini
2024-05-08 14:53 ` [PATCH v2 0/6] This series changes the "isa-bios" MemoryRegion to be an alias rather than a Philippe Mathieu-Daudé
2024-05-08 18:00 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430150643.111976-1-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).