From: "Nicholas Piggin" <npiggin@gmail.com>
To: "BALATON Zoltan" <balaton@eik.bme.hu>, <qemu-devel@nongnu.org>,
<qemu-ppc@nongnu.org>
Cc: "Daniel Henrique Barboza" <danielhb413@gmail.com>
Subject: Re: [PATCH v2 27/28] target/ppc: Remove id_tlbs flag from CPU env
Date: Tue, 07 May 2024 22:30:14 +1000 [thread overview]
Message-ID: <D13EWAGCZ9F6.1LCJ4K7W21C3L@gmail.com> (raw)
In-Reply-To: <5a24db3d48babe4e855707a01954b1827712772f.1714606359.git.balaton@eik.bme.hu>
On Thu May 2, 2024 at 9:43 AM AEST, BALATON Zoltan wrote:
> This flag for split instruction/data TLBs is only set for 6xx soft TLB
> MMU model and not used otherwise so no need to have a separate flag
> for that.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ppc/pegasos2.c | 2 +-
> target/ppc/cpu.h | 1 -
> target/ppc/cpu_init.c | 19 +++++--------------
> target/ppc/helper_regs.c | 1 -
> target/ppc/mmu_common.c | 10 ++--------
> target/ppc/mmu_helper.c | 12 ++----------
> 6 files changed, 10 insertions(+), 35 deletions(-)
>
> diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
> index 04d6decb2b..dfc6fab180 100644
> --- a/hw/ppc/pegasos2.c
> +++ b/hw/ppc/pegasos2.c
> @@ -984,7 +984,7 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
> cpu->env.icache_line_size);
> qemu_fdt_setprop_cell(fdt, cp, "i-cache-line-size",
> cpu->env.icache_line_size);
> - if (cpu->env.id_tlbs) {
> + if (cpu->env.tlb_type == TLB_6XX) {
Want to just add the standard comment here?
/* 6xx has separate TLBs for instructions and data */
Otherwise looks good
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> qemu_fdt_setprop_cell(fdt, cp, "i-tlb-sets", cpu->env.nb_ways);
> qemu_fdt_setprop_cell(fdt, cp, "i-tlb-size", cpu->env.tlb_per_way);
> qemu_fdt_setprop_cell(fdt, cp, "d-tlb-sets", cpu->env.nb_ways);
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index 0ac55d6b25..21e12a4f0d 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -1260,7 +1260,6 @@ struct CPUArchState {
> int tlb_per_way; /* Speed-up helper: used to avoid divisions at run time */
> int nb_ways; /* Number of ways in the TLB set */
> int last_way; /* Last used way used to allocate TLB in a LRU way */
> - int id_tlbs; /* If 1, MMU has separated TLBs for instructions & data */
> int nb_pids; /* Number of available PID registers */
> int tlb_type; /* Type of TLB we're dealing with */
> ppc_tlb_t tlb; /* TLB is optional. Allocate them only if needed */
> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> index c11a69fd90..07ad788e54 100644
> --- a/target/ppc/cpu_init.c
> +++ b/target/ppc/cpu_init.c
> @@ -2117,7 +2117,6 @@ static void init_proc_405(CPUPPCState *env)
> #if !defined(CONFIG_USER_ONLY)
> env->nb_tlb = 64;
> env->nb_ways = 1;
> - env->id_tlbs = 0;
> env->tlb_type = TLB_EMB;
> #endif
> init_excp_4xx(env);
> @@ -2190,7 +2189,6 @@ static void init_proc_440EP(CPUPPCState *env)
> #if !defined(CONFIG_USER_ONLY)
> env->nb_tlb = 64;
> env->nb_ways = 1;
> - env->id_tlbs = 0;
> env->tlb_type = TLB_EMB;
> #endif
> init_excp_BookE(env);
> @@ -2288,7 +2286,6 @@ static void init_proc_440GP(CPUPPCState *env)
> #if !defined(CONFIG_USER_ONLY)
> env->nb_tlb = 64;
> env->nb_ways = 1;
> - env->id_tlbs = 0;
> env->tlb_type = TLB_EMB;
> #endif
> init_excp_BookE(env);
> @@ -2362,7 +2359,6 @@ static void init_proc_440x5(CPUPPCState *env)
> #if !defined(CONFIG_USER_ONLY)
> env->nb_tlb = 64;
> env->nb_ways = 1;
> - env->id_tlbs = 0;
> env->tlb_type = TLB_EMB;
> #endif
> init_excp_BookE(env);
> @@ -2724,7 +2720,6 @@ static void init_proc_e200(CPUPPCState *env)
> #if !defined(CONFIG_USER_ONLY)
> env->nb_tlb = 64;
> env->nb_ways = 1;
> - env->id_tlbs = 0;
> env->tlb_type = TLB_EMB;
> #endif
> init_excp_e200(env, 0xFFFF0000UL);
> @@ -2843,7 +2838,6 @@ static void init_proc_e500(CPUPPCState *env, int version)
> /* Memory management */
> env->nb_pids = 3;
> env->nb_ways = 2;
> - env->id_tlbs = 0;
> switch (version) {
> case fsl_e500v1:
> tlbncfg[0] = register_tlbncfg(2, 1, 1, 0, 256);
> @@ -6800,20 +6794,17 @@ static void init_ppc_proc(PowerPCCPU *cpu)
> }
> /* Allocate TLBs buffer when needed */
> #if !defined(CONFIG_USER_ONLY)
> - if (env->nb_tlb != 0) {
> - int nb_tlb = env->nb_tlb;
> - if (env->id_tlbs != 0) {
> - nb_tlb *= 2;
> - }
> + if (env->nb_tlb) {
> switch (env->tlb_type) {
> case TLB_6XX:
> - env->tlb.tlb6 = g_new0(ppc6xx_tlb_t, nb_tlb);
> + /* 6xx has separate TLBs for instructions and data hence times 2 */
> + env->tlb.tlb6 = g_new0(ppc6xx_tlb_t, 2 * env->nb_tlb);
> break;
> case TLB_EMB:
> - env->tlb.tlbe = g_new0(ppcemb_tlb_t, nb_tlb);
> + env->tlb.tlbe = g_new0(ppcemb_tlb_t, env->nb_tlb);
> break;
> case TLB_MAS:
> - env->tlb.tlbm = g_new0(ppcmas_tlb_t, nb_tlb);
> + env->tlb.tlbm = g_new0(ppcmas_tlb_t, env->nb_tlb);
> break;
> }
> /* Pre-compute some useful values */
> diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c
> index 25258986e3..ed583fe9b3 100644
> --- a/target/ppc/helper_regs.c
> +++ b/target/ppc/helper_regs.c
> @@ -693,7 +693,6 @@ void register_6xx_7xx_soft_tlb(CPUPPCState *env, int nb_tlbs, int nb_ways)
> #if !defined(CONFIG_USER_ONLY)
> env->nb_tlb = nb_tlbs;
> env->nb_ways = nb_ways;
> - env->id_tlbs = 1;
> env->tlb_type = TLB_6XX;
> spr_register(env, SPR_DMISS, "DMISS",
> SPR_NOACCESS, SPR_NOACCESS,
> diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
> index 204b8af455..a0b34f9637 100644
> --- a/target/ppc/mmu_common.c
> +++ b/target/ppc/mmu_common.c
> @@ -130,8 +130,8 @@ int ppc6xx_tlb_getnum(CPUPPCState *env, target_ulong eaddr,
> nr = (eaddr >> TARGET_PAGE_BITS) & (env->tlb_per_way - 1);
> /* Select TLB way */
> nr += env->tlb_per_way * way;
> - /* 6xx have separate TLBs for instructions and data */
> - if (is_code && env->id_tlbs == 1) {
> + /* 6xx has separate TLBs for instructions and data */
> + if (is_code) {
> nr += env->nb_tlb;
> }
>
> @@ -1246,13 +1246,7 @@ static void mmu6xx_dump_mmu(CPUPPCState *env)
> mmu6xx_dump_BATs(env, ACCESS_INT);
> mmu6xx_dump_BATs(env, ACCESS_CODE);
>
> - if (env->id_tlbs != 1) {
> - qemu_printf("ERROR: 6xx MMU should have separated TLB"
> - " for code and data\n");
> - }
> -
> qemu_printf("\nTLBs [EPN EPN + SIZE]\n");
> -
> for (type = 0; type < 2; type++) {
> for (way = 0; way < env->nb_ways; way++) {
> for (entry = env->nb_tlb * type + env->tlb_per_way * way;
> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> index 817836b731..87c611888b 100644
> --- a/target/ppc/mmu_helper.c
> +++ b/target/ppc/mmu_helper.c
> @@ -44,14 +44,8 @@
> static inline void ppc6xx_tlb_invalidate_all(CPUPPCState *env)
> {
> ppc6xx_tlb_t *tlb;
> - int nr, max;
> + int nr, max = 2 * env->nb_tlb;
>
> - /* LOG_SWTLB("Invalidate all TLBs\n"); */
> - /* Invalidate all defined software TLB */
> - max = env->nb_tlb;
> - if (env->id_tlbs == 1) {
> - max *= 2;
> - }
> for (nr = 0; nr < max; nr++) {
> tlb = &env->tlb.tlb6[nr];
> pte_invalidate(&tlb->pte0);
> @@ -307,9 +301,7 @@ void ppc_tlb_invalidate_one(CPUPPCState *env, target_ulong addr)
> switch (env->mmu_model) {
> case POWERPC_MMU_SOFT_6xx:
> ppc6xx_tlb_invalidate_virt(env, addr, 0);
> - if (env->id_tlbs == 1) {
> - ppc6xx_tlb_invalidate_virt(env, addr, 1);
> - }
> + ppc6xx_tlb_invalidate_virt(env, addr, 1);
> break;
> case POWERPC_MMU_32B:
> /*
next prev parent reply other threads:[~2024-05-07 12:31 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 23:43 [PATCH v2 00/28] Misc PPC exception and BookE MMU clean ups BALATON Zoltan
2024-05-01 23:43 ` [PATCH v2 01/28] target/ppc: Fix gen_sc to use correct nip BALATON Zoltan
2024-05-01 23:43 ` [PATCH v2 02/28] target/ppc: Move patching nip from exception handler to helper_scv BALATON Zoltan
2024-05-01 23:43 ` [PATCH v2 03/28] target/ppc: Simplify syscall exception handlers BALATON Zoltan
2024-05-01 23:43 ` [PATCH v2 04/28] target/ppc: Remove unused helper BALATON Zoltan
2024-05-07 9:18 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 05/28] target/ppc/mmu_common.c: Move calculation of a value closer to its usage BALATON Zoltan
2024-05-07 9:19 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 06/28] " BALATON Zoltan
2024-05-07 9:20 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 07/28] target/ppc/mmu_common.c: Remove unneeded local variable BALATON Zoltan
2024-05-07 9:30 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 08/28] target/ppc/mmu_common.c: Simplify checking for real mode BALATON Zoltan
2024-05-07 9:34 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 09/28] target/ppc/mmu_common.c: Drop cases for unimplemented MPC8xx MMU BALATON Zoltan
2024-05-07 9:36 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 10/28] target/ppc/mmu_common.c: Introduce mmu6xx_get_physical_address() BALATON Zoltan
2024-05-07 9:42 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 11/28] target/ppc/mmu_common.c: Rename get_bat_6xx_tlb() BALATON Zoltan
2024-05-07 9:43 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 12/28] target/ppc/mmu_common.c: Split out BookE cases before checking real mode BALATON Zoltan
2024-05-07 9:50 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 13/28] target/ppc/mmu_common.c: Split off real mode cases in get_physical_address_wtlb() BALATON Zoltan
2024-05-07 9:58 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 14/28] target/ppc/mmu_common.c: Inline and remove check_physical() BALATON Zoltan
2024-05-07 10:00 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 15/28] target/ppc/mmu_common.c: Simplify mmubooke_get_physical_address() BALATON Zoltan
2024-05-07 10:03 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 16/28] target/ppc/mmu_common.c: Simplify mmubooke206_get_physical_address() BALATON Zoltan
2024-05-07 10:04 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 17/28] target/ppc/mmu_common.c: Fix misindented qemu_log_mask() calls BALATON Zoltan
2024-05-07 10:05 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 18/28] target/ppc/mmu_common.c: Deindent ppc_jumbo_xlate() BALATON Zoltan
2024-05-07 10:06 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 19/28] target/ppc/mmu_common.c: Replace hard coded constants in ppc_jumbo_xlate() BALATON Zoltan
2024-05-07 10:11 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 20/28] target/ppc/mmu_common.c: Make get_physical_address_wtlb() static BALATON Zoltan
2024-05-07 10:47 ` Nicholas Piggin
2024-05-07 15:31 ` BALATON Zoltan
2024-05-01 23:43 ` [PATCH v2 21/28] target/ppc: Move mmu_ctx_t definition to mmu_common.c BALATON Zoltan
2024-05-07 10:49 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 22/28] target/ppc: Remove ppc_hash32_pp_prot() and reuse common function BALATON Zoltan
2024-05-07 11:35 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 23/28] target/ppc/mmu_common.c: Split off BookE handling from ppc_jumbo_xlate() BALATON Zoltan
2024-05-07 11:51 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 24/28] target/ppc/mmu_common.c: Remove BookE handling from get_physical_address_wtlb() BALATON Zoltan
2024-05-07 12:05 ` Nicholas Piggin
2024-05-07 23:40 ` BALATON Zoltan
2024-05-08 12:54 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 25/28] target/ppc/mmu_common.c: Simplify ppc_booke_xlate() BALATON Zoltan
2024-05-07 12:15 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together BALATON Zoltan
2024-05-07 12:17 ` Nicholas Piggin
2024-05-07 12:31 ` BALATON Zoltan
2024-05-08 12:30 ` Nicholas Piggin
2024-05-08 23:33 ` BALATON Zoltan
2024-05-09 5:57 ` Nicholas Piggin
2024-05-07 15:54 ` BALATON Zoltan
2024-05-01 23:43 ` [PATCH v2 27/28] target/ppc: Remove id_tlbs flag from CPU env BALATON Zoltan
2024-05-07 12:30 ` Nicholas Piggin [this message]
2024-05-07 16:02 ` BALATON Zoltan
2024-05-08 12:37 ` Nicholas Piggin
2024-05-01 23:43 ` [PATCH v2 28/28] target/ppc: Split off common 4xx TLB init BALATON Zoltan
2024-05-07 12:40 ` Nicholas Piggin
2024-05-07 12:45 ` [PATCH v2 00/28] Misc PPC exception and BookE MMU clean ups Nicholas Piggin
2024-05-07 12:51 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D13EWAGCZ9F6.1LCJ4K7W21C3L@gmail.com \
--to=npiggin@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=danielhb413@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).