From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Inès Varhol" <ines.varhol@telecom-paris.fr>,
qemu-devel@nongnu.org, "Luc Michel" <luc@lmichel.fr>,
"Damien Hedde" <damien.hedde@dahe.fr>
Cc: qemu-arm@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Arnaud Minier" <arnaud.minier@telecom-paris.fr>,
"Laurent Vivier" <lvivier@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alistair Francis" <alistair@alistair23.me>,
"Samuel Tardieu" <samuel.tardieu@telecom-paris.fr>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH 3/4] hw/char: Add QOM property for STM32L4x5 USART clock frequency
Date: Mon, 6 May 2024 11:43:45 +0200 [thread overview]
Message-ID: <4717eddc-7564-4bb9-8abf-f42c2253e98e@linaro.org> (raw)
In-Reply-To: <06e98554-3430-49d5-94f3-c5d683327f55@linaro.org>
(+Luc & Damien for Clock API)
On 6/5/24 11:34, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 5/5/24 16:05, Inès Varhol wrote:
>> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
>> ---
>> hw/char/stm32l4x5_usart.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c
>> index fc5dcac0c4..ee7727481c 100644
>> --- a/hw/char/stm32l4x5_usart.c
>> +++ b/hw/char/stm32l4x5_usart.c
>> @@ -26,6 +26,7 @@
>> #include "hw/clock.h"
>> #include "hw/irq.h"
>> #include "hw/qdev-clock.h"
>> +#include "qapi/visitor.h"
>> #include "hw/qdev-properties.h"
>> #include "hw/qdev-properties-system.h"
>> #include "hw/registerfields.h"
>> @@ -523,6 +524,14 @@ static Property stm32l4x5_usart_base_properties[]
>> = {
>> DEFINE_PROP_END_OF_LIST(),
>> };
>> +static void clock_freq_get(Object *obj, Visitor *v,
>> + const char *name, void *opaque, Error **errp)
>> +{
>> + Stm32l4x5UsartBaseState *s = STM32L4X5_USART_BASE(obj);
>> + uint32_t clock_freq_hz = clock_get_hz(s->clk);
>> + visit_type_uint32(v, name, &clock_freq_hz, errp);
>> +}
>> +
>> static void stm32l4x5_usart_base_init(Object *obj)
>> {
>> Stm32l4x5UsartBaseState *s = STM32L4X5_USART_BASE(obj);
>> @@ -534,6 +543,9 @@ static void stm32l4x5_usart_base_init(Object *obj)
>> sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);
>> s->clk = qdev_init_clock_in(DEVICE(s), "clk", NULL, s, 0);
>> +
>> + object_property_add(obj, "clock-freq-hz", "uint32",
>> + clock_freq_get, NULL, NULL, NULL);
>
> Patch LGTM, but I wonder if registering QOM getter without setter
> is recommended. Perhaps we should encourage parity? In normal HW
> emulation we shouldn't update this clock externally, but thinking
> about testing, this could be interesting to introduce jitter.
Orthogonal to this doubt, we could add the clock properties
directly in qdev_init_clock_in(). Seems useful for the QTest
framework.
> Any opinion on this?
>
>> }
>> static int stm32l4x5_usart_base_post_load(void *opaque, int version_id)
>
next prev parent reply other threads:[~2024-05-06 9:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 14:05 [PATCH 0/4] Check clock connection between STM32L4x5 RCC and peripherals Inès Varhol
2024-05-05 14:05 ` [PATCH 1/4] hw/misc: Create STM32L4x5 SYSCFG clock Inès Varhol
2024-05-07 9:50 ` Peter Maydell
2024-05-07 17:30 ` Inès Varhol
2024-05-05 14:05 ` [PATCH 2/4] hw/gpio: Handle clock migration in STM32L4x5 gpios Inès Varhol
2024-05-06 9:38 ` Philippe Mathieu-Daudé
2024-05-05 14:05 ` [PATCH 3/4] hw/char: Add QOM property for STM32L4x5 USART clock frequency Inès Varhol
2024-05-06 9:34 ` Philippe Mathieu-Daudé
2024-05-06 9:43 ` Philippe Mathieu-Daudé [this message]
2024-05-07 9:54 ` Peter Maydell
2024-05-08 14:08 ` Philippe Mathieu-Daudé
2024-05-05 14:05 ` [PATCH 4/4] tests/qtest: Check STM32L4x5 clock connections Inès Varhol
2024-05-06 4:16 ` Thomas Huth
2024-05-06 17:57 ` Inès Varhol
-- strict thread matches above, loose matches on Subject: below --
2024-05-07 18:55 [PATCH 0/4] Check clock connection between STM32L4x5 RCC and peripherals Inès Varhol
2024-05-07 18:55 ` [PATCH 3/4] hw/char: Add QOM property for STM32L4x5 USART clock frequency Inès Varhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4717eddc-7564-4bb9-8abf-f42c2253e98e@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=arnaud.minier@telecom-paris.fr \
--cc=damien.hedde@dahe.fr \
--cc=eduardo@habkost.net \
--cc=ines.varhol@telecom-paris.fr \
--cc=luc@lmichel.fr \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.tardieu@telecom-paris.fr \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).