From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Inès Varhol" <ines.varhol@telecom-paris.fr>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Arnaud Minier" <arnaud.minier@telecom-paris.fr>,
"Laurent Vivier" <lvivier@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alistair Francis" <alistair@alistair23.me>,
"Samuel Tardieu" <samuel.tardieu@telecom-paris.fr>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 2/4] hw/gpio: Handle clock migration in STM32L4x5 gpios
Date: Mon, 6 May 2024 11:38:19 +0200 [thread overview]
Message-ID: <16596e82-46fb-43ca-92ba-dfbfa7bf560e@linaro.org> (raw)
In-Reply-To: <20240505140556.373711-3-ines.varhol@telecom-paris.fr>
Hi Inès,
On 5/5/24 16:05, Inès Varhol wrote:
Fixes: 1cdcfb6e93 ("hw/gpio: Implement STM32L4x5 GPIO")
> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
> ---
> hw/gpio/stm32l4x5_gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/gpio/stm32l4x5_gpio.c b/hw/gpio/stm32l4x5_gpio.c
> index 71bf5fddb2..14e6618d30 100644
> --- a/hw/gpio/stm32l4x5_gpio.c
> +++ b/hw/gpio/stm32l4x5_gpio.c
> @@ -20,6 +20,7 @@
> #include "qemu/log.h"
> #include "hw/gpio/stm32l4x5_gpio.h"
> #include "hw/irq.h"
> +#include "hw/clock.h"
> #include "hw/qdev-clock.h"
> #include "hw/qdev-properties.h"
> #include "qapi/visitor.h"
> @@ -441,6 +442,7 @@ static const VMStateDescription vmstate_stm32l4x5_gpio = {
> VMSTATE_UINT32(ascr, Stm32l4x5GpioState),
> VMSTATE_UINT16(disconnected_pins, Stm32l4x5GpioState),
> VMSTATE_UINT16(pins_connected_high, Stm32l4x5GpioState),
> + VMSTATE_CLOCK(clk, Stm32l4x5GpioState),
IIUC we need to increase vmstate_stm32l4x5_gpio version_id (see
commit 8fd34dc0c4 "hw/arm/armsse: Wire up clocks" for example).
> VMSTATE_END_OF_LIST()
> }
> };
next prev parent reply other threads:[~2024-05-06 9:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 14:05 [PATCH 0/4] Check clock connection between STM32L4x5 RCC and peripherals Inès Varhol
2024-05-05 14:05 ` [PATCH 1/4] hw/misc: Create STM32L4x5 SYSCFG clock Inès Varhol
2024-05-07 9:50 ` Peter Maydell
2024-05-07 17:30 ` Inès Varhol
2024-05-05 14:05 ` [PATCH 2/4] hw/gpio: Handle clock migration in STM32L4x5 gpios Inès Varhol
2024-05-06 9:38 ` Philippe Mathieu-Daudé [this message]
2024-05-05 14:05 ` [PATCH 3/4] hw/char: Add QOM property for STM32L4x5 USART clock frequency Inès Varhol
2024-05-06 9:34 ` Philippe Mathieu-Daudé
2024-05-06 9:43 ` Philippe Mathieu-Daudé
2024-05-07 9:54 ` Peter Maydell
2024-05-08 14:08 ` Philippe Mathieu-Daudé
2024-05-05 14:05 ` [PATCH 4/4] tests/qtest: Check STM32L4x5 clock connections Inès Varhol
2024-05-06 4:16 ` Thomas Huth
2024-05-06 17:57 ` Inès Varhol
-- strict thread matches above, loose matches on Subject: below --
2024-05-07 18:55 [PATCH 0/4] Check clock connection between STM32L4x5 RCC and peripherals Inès Varhol
2024-05-07 18:55 ` [PATCH 2/4] hw/gpio: Handle clock migration in STM32L4x5 gpios Inès Varhol
2024-05-08 8:26 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16596e82-46fb-43ca-92ba-dfbfa7bf560e@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=arnaud.minier@telecom-paris.fr \
--cc=ines.varhol@telecom-paris.fr \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.tardieu@telecom-paris.fr \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).