From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Corey Minyard" <cminyard@mvista.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>
Subject: Re: [RFC PATCH-for-9.1 3/4] hw/i2c: Convert to spec v7 terminology (automatically)
Date: Wed, 8 May 2024 10:55:18 +0200 [thread overview]
Message-ID: <43926368-567e-4392-a2c6-de277016c0c4@redhat.com> (raw)
In-Reply-To: <20240408213339.83149-4-philmd@linaro.org>
On 08/04/2024 23.33, Philippe Mathieu-Daudé wrote:
> One of the biggest change from I2C spec v6 -> v7 is:
>
> • Updated the terms "master/slave" to "controller/target"
>
> Since it follows the inclusive terminology from the "Conscious
> Language in your Open Source Projects" guidelines [*], replace
> the I2C terminology.
>
> Mechanical transformation running:
>
> $ cat i2c_rename.txt | while read old new; do \
> sed -i -e "s/$old/$new/g" $(git grep -l $old); \
> done
>
> Having:
>
> $ cat i2c_rename.txt
> i2c_bus_master i2c_bus_controller
> i2c_schedule_pending_master i2c_schedule_pending_controller
> I2CPendingMasters I2CPendingControllers
> I2CPendingMaster I2CPendingController
> pending_masters pending_controllers
> I2C_SLAVE_CLASS I2C_TARGET_CLASS
> I2C_SLAVE_GET_CLASS I2C_TARGET_GET_CLASS
> I2CSlaveClass I2CTargetClass
> I2CSlave I2CTarget
> TYPE_I2C_SLAVE TYPE_I2C_TARGET
> I2C_SLAVE I2C_TARGET
> i2c_slave_new i2c_target_new
> i2c_slave_create_simple i2c_target_create_simple
> i2c_slave_realize_and_unref i2c_target_realize_and_unref
> i2c_slave_set_address i2c_target_set_address
> VMSTATE_I2C_SLAVE VMSTATE_I2C_TARGET
> vmstate_i2c_slave vmstate_i2c_target
>
> Note, the QOM type definition is not modified, TYPE_I2C_TARGET
> remains defined as "i2c-slave".
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
>
> Inspired-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
...
> @@ -649,29 +649,29 @@ static void witherspoon_bmc_i2c_init(AspeedMachineState *bmc)
> qdev_connect_gpio_out(dev, pca1_leds[i].gpio_id,
> qdev_get_gpio_in(DEVICE(led), 0));
> }
> - i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 3),
> + i2c_target_create_simple(aspeed_i2c_get_bus(&soc->i2c, 3),
> "dps310", 0x76);
So the location of the opening parenthesis changes in a lot of lines in your
patch, but you don't adapt the following line accordingly, so the
indentation is off now. ==> One more reason for not breaking the long lines
in your previous patch.
Thomas
next prev parent reply other threads:[~2024-05-08 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 21:33 [RFC PATCH-for-9.1 0/4] hw/i2c: Convert to spec v7 (inclusive) terminology Philippe Mathieu-Daudé
2024-04-08 21:33 ` [RFC PATCH-for-9.1 1/4] hw/i2c: Fix checkpatch block comment warnings Philippe Mathieu-Daudé
2024-04-08 21:33 ` [RFC PATCH-for-9.1 2/4] hw/i2c: Fix checkpatch line over 80 chars warnings Philippe Mathieu-Daudé
2024-05-08 8:52 ` Thomas Huth
2024-04-08 21:33 ` [RFC PATCH-for-9.1 3/4] hw/i2c: Convert to spec v7 terminology (automatically) Philippe Mathieu-Daudé
2024-04-09 8:58 ` Paolo Bonzini
2024-04-09 9:44 ` Philippe Mathieu-Daudé
2024-04-09 9:00 ` Wolfram Sang
2024-05-08 8:55 ` Thomas Huth [this message]
2024-04-08 21:33 ` [RFC PATCH-for-9.1 4/4] hw/i2c: Convert to spec v7 terminology (manually) Philippe Mathieu-Daudé
2024-05-16 1:48 ` [RFC PATCH-for-9.1 0/4] hw/i2c: Convert to spec v7 (inclusive) terminology Corey Minyard via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43926368-567e-4392-a2c6-de277016c0c4@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=cminyard@mvista.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).