From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Corey Minyard" <cminyard@mvista.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [RFC PATCH-for-9.1 3/4] hw/i2c: Convert to spec v7 terminology (automatically)
Date: Tue, 9 Apr 2024 11:44:22 +0200 [thread overview]
Message-ID: <384195db-6aab-4da0-80ea-d1c925904d14@linaro.org> (raw)
In-Reply-To: <CABgObfaRtv3WwhYzUKSCpee3UQFuwAzUEstX0uFGdRFOV6j4_Q@mail.gmail.com>
On 9/4/24 10:58, Paolo Bonzini wrote:
>
>
> Il lun 8 apr 2024, 23:34 Philippe Mathieu-Daudé <philmd@linaro.org
> <mailto:philmd@linaro.org>> ha scritto:
>
> Note, the QOM type definition is not modified, TYPE_I2C_TARGET
> remains defined as "i2c-slave".
>
>
> Is this actually necessary? The only thing that could break is -global
> but I don't think it matters really.
I remembered some discussion with Gerd where he mentioned we can not
rename a QOM type because it is a stable interface (-device TYPE),
but here I missed the type is abstract, so not user-creatable, thus
it is safe to rename.
Consider the following hunk squashed:
-- >8 --
diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h
index abefee78fd..8908267c17 100644
--- a/include/hw/i2c/i2c.h
+++ b/include/hw/i2c/i2c.h
@@ -24 +24 @@ typedef struct I2CNodeList I2CNodeList;
-#define TYPE_I2C_TARGET "i2c-slave"
+#define TYPE_I2C_TARGET "i2c-target"
---
>
> Paolo
>
>
> [*]
> https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md <https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md>
>
> Inspired-by: Wolfram Sang <wsa+renesas@sang-engineering.com
> <mailto:wsa%2Brenesas@sang-engineering.com>>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org
> <mailto:philmd@linaro.org>>
> ---
> include/hw/display/i2c-ddc.h | 2 +-
> include/hw/gpio/pca9552.h | 2 +-
> include/hw/gpio/pca9554.h | 2 +-
> include/hw/i2c/aspeed_i2c.h | 4 +-
> include/hw/i2c/i2c.h | 66 ++++-----
> include/hw/i2c/i2c_mux_pca954x.h | 2 +-
> include/hw/i2c/smbus_slave.h | 4 +-
> include/hw/nvram/eeprom_at24c.h | 4 +-
> include/hw/sensor/tmp105.h | 2 +-
> hw/arm/aspeed.c | 232 +++++++++++++++----------------
> hw/arm/bananapi_m2u.c | 2 +-
> hw/arm/cubieboard.c | 2 +-
> hw/arm/musicpal.c | 6 +-
> hw/arm/npcm7xx_boards.c | 44 +++---
> hw/arm/nseries.c | 6 +-
> hw/arm/pxa2xx.c | 36 ++---
> hw/arm/realview.c | 2 +-
> hw/arm/spitz.c | 12 +-
> hw/arm/stellaris.c | 2 +-
> hw/arm/tosa.c | 14 +-
> hw/arm/versatilepb.c | 2 +-
> hw/arm/vexpress.c | 2 +-
> hw/arm/z2.c | 20 +--
> hw/audio/wm8750.c | 18 +--
> hw/display/ati.c | 4 +-
> hw/display/i2c-ddc.c | 10 +-
> hw/display/sii9022.c | 16 +--
> hw/display/sm501.c | 2 +-
> hw/display/ssd0303.c | 14 +-
> hw/display/xlnx_dp.c | 2 +-
> hw/gpio/max7310.c | 14 +-
> hw/gpio/pca9552.c | 14 +-
> hw/gpio/pca9554.c | 14 +-
> hw/gpio/pcf8574.c | 12 +-
> hw/i2c/aspeed_i2c.c | 16 +--
> hw/i2c/core.c | 88 ++++++------
> hw/i2c/i2c_mux_pca954x.c | 6 +-
> hw/i2c/imx_i2c.c | 2 +-
> hw/i2c/smbus_slave.c | 12 +-
> hw/input/lm832x.c | 14 +-
> hw/misc/axp2xx.c | 14 +-
> hw/misc/i2c-echo.c | 14 +-
> hw/nvram/eeprom_at24c.c | 22 +--
> hw/ppc/e500.c | 2 +-
> hw/ppc/pnv.c | 4 +-
> hw/ppc/sam460ex.c | 2 +-
> hw/rtc/ds1338.c | 14 +-
> hw/rtc/m41t80.c | 12 +-
> hw/rtc/twl92230.c | 16 +--
> hw/sensor/dps310.c | 14 +-
> hw/sensor/emc141x.c | 16 +--
> hw/sensor/lsm303dlhc_mag.c | 16 +--
> hw/sensor/tmp105.c | 16 +--
> hw/sensor/tmp421.c | 20 +--
> hw/tpm/tpm_tis_i2c.c | 12 +-
> 55 files changed, 461 insertions(+), 461 deletions(-)
next prev parent reply other threads:[~2024-04-09 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 21:33 [RFC PATCH-for-9.1 0/4] hw/i2c: Convert to spec v7 (inclusive) terminology Philippe Mathieu-Daudé
2024-04-08 21:33 ` [RFC PATCH-for-9.1 1/4] hw/i2c: Fix checkpatch block comment warnings Philippe Mathieu-Daudé
2024-04-08 21:33 ` [RFC PATCH-for-9.1 2/4] hw/i2c: Fix checkpatch line over 80 chars warnings Philippe Mathieu-Daudé
2024-05-08 8:52 ` Thomas Huth
2024-04-08 21:33 ` [RFC PATCH-for-9.1 3/4] hw/i2c: Convert to spec v7 terminology (automatically) Philippe Mathieu-Daudé
2024-04-09 8:58 ` Paolo Bonzini
2024-04-09 9:44 ` Philippe Mathieu-Daudé [this message]
2024-04-09 9:00 ` Wolfram Sang
2024-05-08 8:55 ` Thomas Huth
2024-04-08 21:33 ` [RFC PATCH-for-9.1 4/4] hw/i2c: Convert to spec v7 terminology (manually) Philippe Mathieu-Daudé
2024-05-16 1:48 ` [RFC PATCH-for-9.1 0/4] hw/i2c: Convert to spec v7 (inclusive) terminology Corey Minyard via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384195db-6aab-4da0-80ea-d1c925904d14@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=cminyard@mvista.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).