From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH] target/arm: Provide and use H8 and H1_8 macros
Date: Thu, 10 Jun 2021 16:13:34 +0200 [thread overview]
Message-ID: <2a2eaa8d-5e34-9c9c-6991-baea86372b34@amsat.org> (raw)
In-Reply-To: <20210610132505.5827-1-peter.maydell@linaro.org>
On 6/10/21 3:25 PM, Peter Maydell wrote:
> Currently we provide Hn and H1_n macros for accessing the correct
> data within arrays of vector elements of size 1, 2 and 4, accounting
> for host endianness. We don't provide any macros for elements of
> size 8 because there the host endianness doesn't matter. However,
> this does result in awkwardness where we need to pass empty arguments
> to macros, because checkpatch complains about them. The empty
> argument is a little confusing for humans to read as well.
>
> Add H8() and H1_8() macros and use them where we were previously
> passing empty arguments to macros.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is a big patch but it was basically search-n-replaced
> (not entirely automatedly, but conveniently most of the SVE
> H1_8 locations were ", ,").
>
> SVE ZIP, UZP, TRN also have Int128 forms. I haven't attempted
> to provide macros for that case.
> ---
> target/arm/vec_internal.h | 8 +-
> target/arm/sve_helper.c | 258 +++++++++++++++++++-------------------
> target/arm/vec_helper.c | 14 +--
> 3 files changed, 143 insertions(+), 137 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-06-10 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 13:25 [PATCH] target/arm: Provide and use H8 and H1_8 macros Peter Maydell
2021-06-10 14:13 ` Philippe Mathieu-Daudé [this message]
2021-06-10 14:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2eaa8d-5e34-9c9c-6991-baea86372b34@amsat.org \
--to=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).