From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45207C47094 for ; Thu, 10 Jun 2021 14:14:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03498613D9 for ; Thu, 10 Jun 2021 14:14:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03498613D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrLSU-0008MN-7Q for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 10:14:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrLRI-0006dW-Bq; Thu, 10 Jun 2021 10:13:44 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:36770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrLRD-0004ba-R2; Thu, 10 Jun 2021 10:13:44 -0400 Received: by mail-wr1-x42d.google.com with SMTP id e11so2525815wrg.3; Thu, 10 Jun 2021 07:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TGKY2F8YUqzUdh6K7kHDCawNhVib0r59ys0eKB6lFhY=; b=guTqXFJpny9bcLDbDTEv4fEIxCVlxNjdUDPrjII4dOp8jB70HAKY67ujuOhYSOPCNn yW5gUiw3gKbO6fV7xbHVGAeVzN/CZ1kb105Ckkh/d3IlLKtcjb9kpRmg6151XvogSFFI HFFHRzeiA5rFOYpRo5fIRjJao/DHrQy2KQvc9sjw1fW4/iOthwLNuVmVtQhvvdqUXt1H AVHeS+kuH5bDHaoZ0zYTQIO4gKh3UBWP6zuSFskje65tV/P58wvMM1/MLj4dE1oCJrUq y4uI53j84Tr1c4y4C2wyPc8wfTAbWIWsCTzN+6jGYZEzmGDufL94FvPCfkkTfoB5nFKj hHFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TGKY2F8YUqzUdh6K7kHDCawNhVib0r59ys0eKB6lFhY=; b=qMH97tELWihNEO55Ng2D4fuuLM1rgp5a4P5pHrzeCY+Rd3qSr82agUbQOWl6UpByG7 xwuRP7pjedcocmKuPecqNByIp8VcuHtwFsue8K7U+JRjpwFIwlcxHLGFRbCTyHMKRxM2 TFW6xYL4GpNCGqT95PDckNpfJolV5UF/eDK+HW3/e2zMPuU5M1ItN8dWxLBteTjbnuh1 UFVrYtECM8m3ZTMURR/DCtyNblBfzmh+rcZy+451S10hzyv0BUqBejlq3icD2XXkWTRe jlM4H1FieUfZuk3htSC+lG40vCMuWLtOHbpnUvlhajSee9gF8fdu6O8CBkATpH+Ya2i7 o2Cw== X-Gm-Message-State: AOAM530pkgq6JdglEcuwxNflV4do5lJLCEn3kTKEnqcY+DiYFUIjoNKr X82hMYEzzMLZr4j/nCeKLpk= X-Google-Smtp-Source: ABdhPJxkC+0+wyUCNqxnHpWDtGie+Eic62fQbcOCALPDbcdw5A8I6yQwGnep/QDsjOuW3jEh+kCQyQ== X-Received: by 2002:a5d:54c8:: with SMTP id x8mr5823994wrv.109.1623334416637; Thu, 10 Jun 2021 07:13:36 -0700 (PDT) Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id u12sm3780479wrr.40.2021.06.10.07.13.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 07:13:35 -0700 (PDT) Subject: Re: [PATCH] target/arm: Provide and use H8 and H1_8 macros To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210610132505.5827-1-peter.maydell@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <2a2eaa8d-5e34-9c9c-6991-baea86372b34@amsat.org> Date: Thu, 10 Jun 2021 16:13:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210610132505.5827-1-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/10/21 3:25 PM, Peter Maydell wrote: > Currently we provide Hn and H1_n macros for accessing the correct > data within arrays of vector elements of size 1, 2 and 4, accounting > for host endianness. We don't provide any macros for elements of > size 8 because there the host endianness doesn't matter. However, > this does result in awkwardness where we need to pass empty arguments > to macros, because checkpatch complains about them. The empty > argument is a little confusing for humans to read as well. > > Add H8() and H1_8() macros and use them where we were previously > passing empty arguments to macros. > > Suggested-by: Richard Henderson > Signed-off-by: Peter Maydell > --- > This is a big patch but it was basically search-n-replaced > (not entirely automatedly, but conveniently most of the SVE > H1_8 locations were ", ,"). > > SVE ZIP, UZP, TRN also have Int128 forms. I haven't attempted > to provide macros for that case. > --- > target/arm/vec_internal.h | 8 +- > target/arm/sve_helper.c | 258 +++++++++++++++++++------------------- > target/arm/vec_helper.c | 14 +-- > 3 files changed, 143 insertions(+), 137 deletions(-) Reviewed-by: Philippe Mathieu-Daudé