From: Patrick Williams <patrick@stwcx.xyz>
To: Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: openbmc@lists.ozlabs.org, Joel Stanley <joel@jms.id.au>,
Peter Yin <peteryin.openbmc@gmail.com>
Subject: Re: [PATCH u-boot, v2019.04-aspeed-openbmc v1 1/1] ARM: dts: Aspeed: Add Facebook common dts
Date: Wed, 15 May 2024 21:37:40 -0500 [thread overview]
Message-ID: <ZkVxdHBLOG2BeRui@heinlein.vulture-banana.ts.net> (raw)
In-Reply-To: <ff7a6703c15a93f5f776caa836f0d0ccf870415b.camel@codeconstruct.com.au>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Thu, May 16, 2024 at 10:30:30AM +0930, Andrew Jeffery wrote:
> On Wed, 2024-05-15 at 17:41 +0800, Peter Yin wrote:
> > Hi Andrew,
> > Thank you for your reply, Do you mean something like this?
> > compatible = "facebook,harma-bmc", "facebook,minerva-bmc", "aspeed,ast2600";
> >
>
> Right. It removes the nebulous "common" concept that might be upset by
> future changes.
I agree that just "common" is probably not appropriate because this
device tree only covers ast2600-based platforms.
We are trying to design our BMC hardware such that at a u-boot level,
the same device tree can be used for most of our platforms. This is
partially so we can avoid having to add new changes for u-boot for every
new platform.
Should we do something like "facebook,ast2600-standard"?
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-05-16 2:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 14:49 [PATCH u-boot, v2019.04-aspeed-openbmc v1 1/1] ARM: dts: Aspeed: Add Facebook common dts Peter Yin
2024-05-13 23:52 ` Andrew Jeffery
2024-05-15 9:41 ` Peter Yin
2024-05-16 1:00 ` Andrew Jeffery
2024-05-16 2:37 ` Patrick Williams [this message]
2024-05-16 23:36 ` Andrew Jeffery
2024-05-17 1:19 ` Patrick Williams
2024-05-17 1:30 ` Andrew Jeffery
2024-05-17 1:59 ` Patrick Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkVxdHBLOG2BeRui@heinlein.vulture-banana.ts.net \
--to=patrick@stwcx.xyz \
--cc=andrew@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=peteryin.openbmc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).