From: Peter Yin <peteryin.openbmc@gmail.com>
To: Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: openbmc@lists.ozlabs.org, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH u-boot, v2019.04-aspeed-openbmc v1 1/1] ARM: dts: Aspeed: Add Facebook common dts
Date: Wed, 15 May 2024 17:41:40 +0800 [thread overview]
Message-ID: <CAPSyxFQ0DWMMAV87NUW-wmt8hudeK2PSDdgWCuiTbthDwAd=vw@mail.gmail.com> (raw)
In-Reply-To: <fe42afa01a7980d8934f437fbb01e2b27d46d7d9.camel@codeconstruct.com.au>
Hi Andrew,
Thank you for your reply, Do you mean something like this?
compatible = "facebook,harma-bmc", "facebook,minerva-bmc", "aspeed,ast2600";
Thanks,
Peter.
On Tue, May 14, 2024 at 7:52 AM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Mon, 2024-05-13 at 22:49 +0800, Peter Yin wrote:
> > Initial introduction of Facebook common
> > equipped with Aspeed 2600 BMC SoC.
> >
> > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> > ---
> > arch/arm/dts/Makefile | 1 +
> > arch/arm/dts/ast2600-fb.dts | 66 +++++++++++++++++++++++++++++++++++++
> > 2 files changed, 67 insertions(+)
> > create mode 100644 arch/arm/dts/ast2600-fb.dts
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> > index 6f4b4d8a17..3740a4452d 100755
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -686,6 +686,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> > ast2600-dcscm.dtb \
> > ast2600-evb-ecc.dtb \
> > ast2600-evb.dtb \
> > + ast2600-fb.dtb \
> > ast2600-fpga.dtb \
> > ast2600-greatlakes.dtb \
> > ast2600-intel.dtb \
> > diff --git a/arch/arm/dts/ast2600-fb.dts b/arch/arm/dts/ast2600-fb.dts
> > new file mode 100644
> > index 0000000000..69ff575419
> > --- /dev/null
> > +++ b/arch/arm/dts/ast2600-fb.dts
> > @@ -0,0 +1,66 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +// Copyright (c) 2023 Meta Platforms Inc.
> > +/dts-v1/;
> > +
> > +#include "ast2600-u-boot.dtsi"
> > +
> > +/ {
> > + model = "Facebook Common BMC";
> > + compatible = "facebook,common-bmc", "aspeed,ast2600";
>
> I'm not convinced about "facebook,common-bmc" as a compatible. Is there
> actually a reason to specify anything here other than "aspeed,ast2600"?
>
> Alternatively, perhaps list all the relevant platforms, like the p10bmc
> dts?
>
> ```
> $ git grep aspeed,ast2600 arch/arm/dts/ast2600-p10bmc.dts
> arch/arm/dts/ast2600-p10bmc.dts: compatible = "ibm,everest-bmc", "ibm,rainier-bmc", "ibm,p10bmc", "aspeed,ast2600";
> ```
>
> Andrew
next prev parent reply other threads:[~2024-05-15 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 14:49 [PATCH u-boot, v2019.04-aspeed-openbmc v1 1/1] ARM: dts: Aspeed: Add Facebook common dts Peter Yin
2024-05-13 23:52 ` Andrew Jeffery
2024-05-15 9:41 ` Peter Yin [this message]
2024-05-16 1:00 ` Andrew Jeffery
2024-05-16 2:37 ` Patrick Williams
2024-05-16 23:36 ` Andrew Jeffery
2024-05-17 1:19 ` Patrick Williams
2024-05-17 1:30 ` Andrew Jeffery
2024-05-17 1:59 ` Patrick Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPSyxFQ0DWMMAV87NUW-wmt8hudeK2PSDdgWCuiTbthDwAd=vw@mail.gmail.com' \
--to=peteryin.openbmc@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).