($INBOX_DIR/description missing)
 help / color / mirror / Atom feed
From: Jonah =?unknown-8bit?q?Br=C3=BCchert?= <jbb.prv@gmx.de>
To: ofono@ofono.org
Subject: Adding support for building phonesim with Qt 6
Date: Mon, 18 Jan 2021 17:46:14 +0100	[thread overview]
Message-ID: <20210118164621.52831-1-jbb.prv@gmx.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Dear ofono maintainers,

Qt 6 is out now, and it was possible to add support for building phonesim
with it without too much effort.

Unfortunately, I couldn't find a pkgconfig file for the Qt5Compat module in Qt6,
so this patchset includes a port of the buildsystem to CMake,
which is the recommended buildsystem for Qt 6, which Qt now uses itself.
It allows quite easily supporting Qt5 and Qt6 with not much code.
Of course a change of the buildsystem might need more discussion,
so obviously feel free to reject this if it doesn't fit your plans.

As a compromise, you could also just skip the patch that removes the old buildsystems,
and provide two choices, but this is in my opinion unnecessary maintainance load.

Regarding testing the build with Qt 6, you can use the Qt installer from the Qt Company.
Make sure to install the Qt5Compat module, as it's still needed for QTextCodec.

Since the installer installs Qt 6 to a custom prefix, it is necessary to pass it to cmake, like this:

  cmake -DCMAKE_PREFIX_PATH=~/.local/Qt/6.0.1/gcc_64

(Assuming ~/.local/Qt was choosen as install destination)

Yours sincerely,
Jonah Brüchert



             reply	other threads:[~2021-01-18 16:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 16:46 Jonah =?unknown-8bit?q?Br=C3=BCchert?= [this message]
2021-01-18 16:46 ` [PATCH phonesim 1/7] Add CMake build system Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-18 16:46 ` [PATCH phonesim 2/7] Use quotes to include local header files Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:14   ` Denis Kenzior
2021-01-18 16:46 ` [PATCH phonesim 3/7] Remove autotools build system Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:20   ` Denis Kenzior
2021-01-18 16:46 ` [PATCH phonesim 4/7] Update README Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-18 16:46 ` [PATCH phonesim 5/7] qwsppdu: Port QDateTime deprecations Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:15   ` Denis Kenzior
2021-01-18 16:46 ` [PATCH phonesim 6/7] Port to Qt 6 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:21   ` Denis Kenzior
2021-01-18 16:46 ` [PATCH phonesim 7/7] Replace uneccessary uses of QTextCodec to convert to unicode Jonah =?unknown-8bit?q?Br=C3=BCchert?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118164621.52831-1-jbb.prv@gmx.de \
    --to=jbb.prv@gmx.de \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).