($INBOX_DIR/description missing)
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH phonesim 6/7] Port to Qt 6
Date: Mon, 25 Jan 2021 13:21:29 -0600	[thread overview]
Message-ID: <1fa4bbf2-2206-b73e-a187-4a6cd414ae3d@gmail.com> (raw)
In-Reply-To: <20210118164621.52831-7-jbb.prv@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Hi Jonah,

On 1/18/21 10:46 AM, Jonah Brüchert wrote:
> ---
>   CMakeLists.txt              | 10 +++++++---
>   src/CMakeLists.txt          |  6 +++++-
>   src/control.cpp             |  8 +++-----
>   src/hardwaremanipulator.cpp |  1 -
>   src/phonesim.cpp            |  2 +-
>   src/qsimcommand.cpp         |  2 +-
>   src/qwsppdu.cpp             | 12 ++++++------
>   7 files changed, 23 insertions(+), 18 deletions(-)
> 

Can the code changes be made standalone, without the build-system bits?

Regards,
-Denis

  reply	other threads:[~2021-01-25 19:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 16:46 Adding support for building phonesim with Qt 6 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-18 16:46 ` [PATCH phonesim 1/7] Add CMake build system Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-18 16:46 ` [PATCH phonesim 2/7] Use quotes to include local header files Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:14   ` Denis Kenzior
2021-01-18 16:46 ` [PATCH phonesim 3/7] Remove autotools build system Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:20   ` Denis Kenzior
2021-01-18 16:46 ` [PATCH phonesim 4/7] Update README Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-18 16:46 ` [PATCH phonesim 5/7] qwsppdu: Port QDateTime deprecations Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:15   ` Denis Kenzior
2021-01-18 16:46 ` [PATCH phonesim 6/7] Port to Qt 6 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2021-01-25 19:21   ` Denis Kenzior [this message]
2021-01-18 16:46 ` [PATCH phonesim 7/7] Replace uneccessary uses of QTextCodec to convert to unicode Jonah =?unknown-8bit?q?Br=C3=BCchert?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fa4bbf2-2206-b73e-a187-4a6cd414ae3d@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).