MPTCP Archive mirror
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3
Date: Wed,  6 Mar 2024 09:40:50 +0800	[thread overview]
Message-ID: <cover.1709688778.git.tanggeliang@kylinos.cn> (raw)

From: Geliang Tang <tanggeliang@kylinos.cn>

v13:
 - fix the shellcheck error reported by CI in patch 8
 - rebased

v12:
 - patch 1 Drop one more 1>&2, and update commit log
 - patch 2 use port_base=10000 instead of PORT=0
 - patch 4 fix the TAP output
 - patch 8 a new patch
 - patch 9 drop _printf in userspace_pm.sh

v11:
 - fix the shellcheck error in v10

v10:
 - split two more patches (#4 and #5) from #6 and #7
 - update commit logs

v9:
 - move print_larger_title from patch 5 to patch 2
 - move MPTCP_LIB_TEST_FORMAT to a more suitable location in patch 4 and
   patch 5

v8:
 - address every comment from Matt in v7.

v7:
 - address every comment from Matt in v6.

v6:
 - only include the first 7 patches in v5
 - add mptcp_lib_pr_* helpers
 - add print_title helpers
 - align the output of simult_flows.sh

v5:
 - don't use mptcp_lib_print_test_counter in mptcp_join.sh, it breaks
   skip_test().

v4:
 - set test_cnt to 0, use ++counter in mptcp_lib_print_test_counter() to
   fix the following mismatched test counters:

# 012 userspace pm server fullmesh
#       syn                                 [ OK ]
#       synack                              [ OK ]
#       ack                                 [ OK ]
#       add                                 [ OK ]
#       echo                                [FAIL] got 1 ADD_ADDR echo[s] expected 2
# Server ns stats
# TcpPassiveOpens                 5                  0.0
# TcpInSegs                       25                 0.0
... ...
#
# 1 failure(s) has(ve) been detected:
#       - 13: userspace pm server fullmesh

v3:
 - fix shellcheck errors in v2

v2:
 - fix shellcheck errors in v1
 - print test results with counters

Geliang Tang (9):
  selftests: mptcp: print all error messages to stdout
  selftests: mptcp: connect: add dedicated port counter
  selftests: mptcp: connect: fix misaligned output
  selftests: mptcp: sockopt: print every test result
  selftests: mptcp: export TEST_COUNTER variable
  selftests: mptcp: add print_title in mptcp_lib
  selftests: mptcp: print test results with counters
  selftests: mptcp: connect: use += operator to append strings
  selftests: mptcp: print test results with colors

 tools/testing/selftests/net/mptcp/diag.sh     |  19 ++-
 .../selftests/net/mptcp/mptcp_connect.sh      | 123 ++++++++++--------
 .../testing/selftests/net/mptcp/mptcp_join.sh |  28 ++--
 .../testing/selftests/net/mptcp/mptcp_lib.sh  |  42 +++++-
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  44 ++++---
 .../testing/selftests/net/mptcp/pm_netlink.sh |   5 +-
 .../selftests/net/mptcp/simult_flows.sh       |  14 +-
 .../selftests/net/mptcp/userspace_pm.sh       |  28 ++--
 8 files changed, 163 insertions(+), 140 deletions(-)

-- 
2.40.1


             reply	other threads:[~2024-03-06  1:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  1:40 Geliang Tang [this message]
2024-03-06  1:40 ` [PATCH mptcp-next v13 1/9] selftests: mptcp: print all error messages to stdout Geliang Tang
2024-03-06  1:40 ` [PATCH mptcp-next v13 2/9] selftests: mptcp: connect: add dedicated port counter Geliang Tang
2024-03-06 12:02   ` Matthieu Baerts
2024-03-06  1:40 ` [PATCH mptcp-next v13 3/9] selftests: mptcp: connect: fix misaligned output Geliang Tang
2024-03-06  1:40 ` [PATCH mptcp-next v13 4/9] selftests: mptcp: sockopt: print every test result Geliang Tang
2024-03-06  1:40 ` [PATCH mptcp-next v13 5/9] selftests: mptcp: export TEST_COUNTER variable Geliang Tang
2024-03-06  1:40 ` [PATCH mptcp-next v13 6/9] selftests: mptcp: add print_title in mptcp_lib Geliang Tang
2024-03-06  1:40 ` [PATCH mptcp-next v13 7/9] selftests: mptcp: print test results with counters Geliang Tang
2024-03-06 12:04   ` Matthieu Baerts
2024-03-06  1:40 ` [PATCH mptcp-next v13 8/9] selftests: mptcp: connect: use += operator to append strings Geliang Tang
2024-03-06  1:40 ` [PATCH mptcp-next v13 9/9] selftests: mptcp: print test results with colors Geliang Tang
2024-03-06  2:33   ` selftests: mptcp: print test results with colors: Tests Results MPTCP CI
2024-03-06  2:49   ` MPTCP CI
2024-03-06 12:04   ` [PATCH mptcp-next v13 9/9] selftests: mptcp: print test results with colors Matthieu Baerts
2024-03-06 12:01 ` [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3 Matthieu Baerts
2024-03-06 15:28   ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1709688778.git.tanggeliang@kylinos.cn \
    --to=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=tanggeliang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).