From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3
Date: Wed, 6 Mar 2024 16:28:28 +0100 [thread overview]
Message-ID: <55dbc24f-c3ad-4761-a785-5f6c4b0ebd5c@kernel.org> (raw)
In-Reply-To: <46b9be01-3fce-49a2-b9f9-e936405712c1@kernel.org>
Hi Geliang,
On 06/03/2024 13:01, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 06/03/2024 02:40, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> v13:
>> - fix the shellcheck error reported by CI in patch 8
>> - rebased
>>
>> v12:
>> - patch 1 Drop one more 1>&2, and update commit log
>> - patch 2 use port_base=10000 instead of PORT=0
>> - patch 4 fix the TAP output
>> - patch 8 a new patch
>> - patch 9 drop _printf in userspace_pm.sh
>
> Thank you for the new version and the changelog. This v13 looks good to me.
>
> Before applying the series, I have 3 suggestions (see my comments on
> patches 2, 3, 9), and one important question (from v11):
>
> Did you check the output when you force failure (e.g. by modifying the
> code to force and issue, e.g. changing counters, set ret values, etc.)?
> Just to make sure they are still presented correctly, and if we still
> catch them!
I just applied the patches in our tree (with the modifications I
suggested), so we can discuss them at the meeting today to check if we
send them before the end of the merge window.
Please tell me if the modifications I did were OK or not, and more
importantly, if you checked we are still catching and printing errors
correctly.
New patches for t/upstream:
- 1078cbfbcaca: selftests: mptcp: print all error messages to stdout
- 41d8173fc08e: selftests: mptcp: connect: add dedicated port counter
- 2f5133832972: selftests: mptcp: connect: fix misaligned output
- 675afbc67f16: selftests: mptcp: sockopt: print every test result
- ea343f146c45: selftests: mptcp: export TEST_COUNTER variable
- 7f8d83dedeec: selftests: mptcp: add print_title in mptcp_lib
- a7107253146f: selftests: mptcp: print test results with counters
- 4d5fa38b0feb: selftests: mptcp: connect: use += operator to append strings
- eb2df7f20113: selftests: mptcp: print test results with colors
- Results: 22573260e303..f5104afeca7c (export)
My modifications:
- 24a6ed34b014: Squash to "selftests: mptcp: connect: add dedicated port
counter"
- d1395cdf78c9: tg:msg: 'prot_base' (typo) -> 'port'
- 29f333cf764b: conflict in t/selftests-mptcp-export-TEST_COUNTER-variable
- a7d331066c9a: conflict in
t/selftests-mptcp-print-test-results-with-counters
- f6a25c3bc6f2: Squash to "selftests: mptcp: print test results with
counters"
- 8664917a10d3: Squash to "selftests: mptcp: print test results with colors"
- Results: f5104afeca7c..03439b759bbc (export)
Tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20240306T152450
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-03-06 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 1:40 [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3 Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 1/9] selftests: mptcp: print all error messages to stdout Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 2/9] selftests: mptcp: connect: add dedicated port counter Geliang Tang
2024-03-06 12:02 ` Matthieu Baerts
2024-03-06 1:40 ` [PATCH mptcp-next v13 3/9] selftests: mptcp: connect: fix misaligned output Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 4/9] selftests: mptcp: sockopt: print every test result Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 5/9] selftests: mptcp: export TEST_COUNTER variable Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 6/9] selftests: mptcp: add print_title in mptcp_lib Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 7/9] selftests: mptcp: print test results with counters Geliang Tang
2024-03-06 12:04 ` Matthieu Baerts
2024-03-06 1:40 ` [PATCH mptcp-next v13 8/9] selftests: mptcp: connect: use += operator to append strings Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 9/9] selftests: mptcp: print test results with colors Geliang Tang
2024-03-06 2:33 ` selftests: mptcp: print test results with colors: Tests Results MPTCP CI
2024-03-06 2:49 ` MPTCP CI
2024-03-06 12:04 ` [PATCH mptcp-next v13 9/9] selftests: mptcp: print test results with colors Matthieu Baerts
2024-03-06 12:01 ` [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3 Matthieu Baerts
2024-03-06 15:28 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55dbc24f-c3ad-4761-a785-5f6c4b0ebd5c@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).