From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Mario Limonciello <mario.limonciello@amd.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, tobrohl@gmail.com, aalsing@gmail.com,
Dhaval.Giani@amd.com, xmb8dsv4@gmail.com, x86@kernel.org
Subject: Re: [PATCH 4/4] rtc: Extend timeout for waiting for UIP to clear to 1s
Date: Sat, 18 Nov 2023 20:25:47 +0100 [thread overview]
Message-ID: <c6c678c1-bd75-4fb2-bf51-e1a745a62a2d@o2.pl> (raw)
In-Reply-To: <20231117063220.65093-5-mario.limonciello@amd.com>
W dniu 17.11.2023 o 07:32, Mario Limonciello pisze:
> Specs don't say anything about UIP being cleared within 10ms. They
> only say that UIP won't occur for another 244uS. If a long NMI occurs
> while UIP is still updating it might not be possible to get valid
> data in 10ms.
>
> This has been observed in the wild that around s2idle some calls can
> take up to 480ms before UIP is clear.
>
> Adjust callers from outside an interrupt context to wait for up to a
> 1s instead of 10ms.
>
> Reported-by: xmb8dsv4@gmail.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217626
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> arch/x86/kernel/rtc.c | 2 +-
> drivers/base/power/trace.c | 2 +-
> drivers/rtc/rtc-cmos.c | 2 +-
> drivers/rtc/rtc-mc146818-lib.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
Consider:
Fixes: ec5895c0f2d8 ("rtc: mc146818-lib: extract mc146818_avoid_UIP")
If you would like to Cc: stable this patch,
commit d2a632a8a117 ("rtc: mc146818-lib: reduce RTC_UIP polling period")
is a prerequisite.
Greetings,
Mateusz
prev parent reply other threads:[~2023-11-18 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 6:32 [PATCH 0/4] Extend time to wait for UIP for some callers Mario Limonciello
2023-11-17 6:32 ` [PATCH 1/4] rtc: mc146818-lib: Adjust failure return code for mc146818_get_time() Mario Limonciello
2023-11-17 6:32 ` [PATCH 2/4] rtc: Adjust failure return code for cmos_set_alarm() Mario Limonciello
2023-11-18 18:55 ` Mateusz Jończyk
2023-11-17 6:32 ` [PATCH 3/4] rtc: Add support for configuring the UIP timeout for RTC reads Mario Limonciello
2023-11-18 19:06 ` Mateusz Jończyk
2023-11-17 6:32 ` [PATCH 4/4] rtc: Extend timeout for waiting for UIP to clear to 1s Mario Limonciello
2023-11-18 19:25 ` Mateusz Jończyk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c678c1-bd75-4fb2-bf51-e1a745a62a2d@o2.pl \
--to=mat.jonczyk@o2.pl \
--cc=Dhaval.Giani@amd.com \
--cc=a.zummo@towertech.it \
--cc=aalsing@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=tobrohl@gmail.com \
--cc=x86@kernel.org \
--cc=xmb8dsv4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).