From: Mario Limonciello <mario.limonciello@amd.com>
To: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: "open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <tobrohl@gmail.com>,
<aalsing@gmail.com>, <Dhaval.Giani@amd.com>, <xmb8dsv4@gmail.com>,
<x86@kernel.org>, Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 2/4] rtc: Adjust failure return code for cmos_set_alarm()
Date: Fri, 17 Nov 2023 00:32:18 -0600 [thread overview]
Message-ID: <20231117063220.65093-3-mario.limonciello@amd.com> (raw)
In-Reply-To: <20231117063220.65093-1-mario.limonciello@amd.com>
When mc146818_avoid_UIP() fails to return a valid value, this is because
UIP didn't clear in the timeout period. Adjust the return code in this
case to -ETIMEDOUT.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/rtc/rtc-cmos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 228fb2d11c70..b39890a5531e 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -557,7 +557,7 @@ static int cmos_set_alarm(struct device *dev, struct rtc_wkalrm *t)
* Use mc146818_avoid_UIP() to avoid this.
*/
if (!mc146818_avoid_UIP(cmos_set_alarm_callback, &p))
- return -EIO;
+ return -ETIMEDOUT;
cmos->alarm_expires = rtc_tm_to_time64(&t->time);
--
2.34.1
next prev parent reply other threads:[~2023-11-17 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 6:32 [PATCH 0/4] Extend time to wait for UIP for some callers Mario Limonciello
2023-11-17 6:32 ` [PATCH 1/4] rtc: mc146818-lib: Adjust failure return code for mc146818_get_time() Mario Limonciello
2023-11-17 6:32 ` Mario Limonciello [this message]
2023-11-18 18:55 ` [PATCH 2/4] rtc: Adjust failure return code for cmos_set_alarm() Mateusz Jończyk
2023-11-17 6:32 ` [PATCH 3/4] rtc: Add support for configuring the UIP timeout for RTC reads Mario Limonciello
2023-11-18 19:06 ` Mateusz Jończyk
2023-11-17 6:32 ` [PATCH 4/4] rtc: Extend timeout for waiting for UIP to clear to 1s Mario Limonciello
2023-11-18 19:25 ` Mateusz Jończyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117063220.65093-3-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Dhaval.Giani@amd.com \
--cc=a.zummo@towertech.it \
--cc=aalsing@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=tobrohl@gmail.com \
--cc=x86@kernel.org \
--cc=xmb8dsv4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).