From: Breno Leitao <leitao@debian.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
kuba@kernel.org, keescook@chromium.org,
"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] IB/hfi1: allocate dummy net_device dynamically
Date: Mon, 11 Mar 2024 08:32:03 -0700 [thread overview]
Message-ID: <Ze8j8yWyXCQtwcOJ@gmail.com> (raw)
In-Reply-To: <6460dd4b-9b65-49df-beaf-05412e42f706@cornelisnetworks.com>
Hello Dennis,
On Mon, Mar 11, 2024 at 08:05:45AM -0400, Dennis Dalessandro wrote:
> On 3/8/24 1:29 PM, Breno Leitao wrote:
> > struct net_device shouldn't be embedded into any structure, instead,
> > the owner should use the priv space to embed their state into net_device.
> >
> > Embedding net_device into structures prohibits the usage of flexible
> > arrays in the net_device structure. For more details, see the discussion
> > at [1].
> >
> > Un-embed the net_device from struct iwl_trans_pcie by converting it
> > into a pointer. Then use the leverage alloc_netdev() to allocate the
> > net_device object at iwl_trans_pcie_alloc.
>
> What does an Omni-Path Architecture driver from Cornelis Networks have to do
> with an Intel wireless driver?
That is an oversight. I will fix it in v2. Sorry about it.
> > The private data of net_device becomes a pointer for the struct
> > iwl_trans_pcie, so, it is easy to get back to the iwl_trans_pcie parent
> > given the net_device object.
> >
> > [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > drivers/infiniband/hw/hfi1/netdev.h | 2 +-
> > drivers/infiniband/hw/hfi1/netdev_rx.c | 9 +++++++--
> > 2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/netdev.h b/drivers/infiniband/hw/hfi1/netdev.h
> > index 8aa074670a9c..07c8f77c9181 100644
> > --- a/drivers/infiniband/hw/hfi1/netdev.h
> > +++ b/drivers/infiniband/hw/hfi1/netdev.h
> > @@ -49,7 +49,7 @@ struct hfi1_netdev_rxq {
> > * When 0 receive queues will be freed.
> > */
> > struct hfi1_netdev_rx {
> > - struct net_device rx_napi;
> > + struct net_device *rx_napi;
> > struct hfi1_devdata *dd;
> > struct hfi1_netdev_rxq *rxq;
> > int num_rx_q;
> > diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> > index 720d4c85c9c9..5c26a69fa2bb 100644
> > --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> > +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> > @@ -188,7 +188,7 @@ static int hfi1_netdev_rxq_init(struct hfi1_netdev_rx *rx)
> > int i;
> > int rc;
> > struct hfi1_devdata *dd = rx->dd;
> > - struct net_device *dev = &rx->rx_napi;
> > + struct net_device *dev = rx->rx_napi;
> >
> > rx->num_rx_q = dd->num_netdev_contexts;
> > rx->rxq = kcalloc_node(rx->num_rx_q, sizeof(*rx->rxq),
> > @@ -360,7 +360,11 @@ int hfi1_alloc_rx(struct hfi1_devdata *dd)
> > if (!rx)
> > return -ENOMEM;
> > rx->dd = dd;
> > - init_dummy_netdev(&rx->rx_napi);
> > + rx->rx_napi = alloc_netdev(sizeof(struct iwl_trans_pcie *),
> > + "dummy", NET_NAME_UNKNOWN,
> > + init_dummy_netdev);
>
> Again with the iwl stuff? Please do not stuff to the mailing list that doesn't
> even compile....
>
> CC [M] drivers/infiniband/hw/hfi1/verbs.o
> CC [M] drivers/infiniband/hw/hfi1/verbs_txreq.o
> CC [M] drivers/infiniband/hw/hfi1/vnic_main.o
> In file included from ./include/net/sock.h:46,
> from ./include/linux/tcp.h:19,
> from ./include/linux/ipv6.h:95,
> from ./include/net/ipv6.h:12,
> from ./include/rdma/ib_verbs.h:25,
> from ./include/rdma/ib_hdrs.h:11,
> from drivers/infiniband/hw/hfi1/hfi.h:29,
> from drivers/infiniband/hw/hfi1/sdma.h:15,
> from drivers/infiniband/hw/hfi1/netdev_rx.c:11:
> drivers/infiniband/hw/hfi1/netdev_rx.c: In function ‘hfi1_alloc_rx’:
> drivers/infiniband/hw/hfi1/netdev_rx.c:365:36: error: passing argument 4 of
> ‘alloc_netdev_mqs’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> 365 | init_dummy_netdev);
> | ^~~~~~~~~~~~~~~~~
> | |
> | int (*)(struct net_device *)
> ./include/linux/netdevice.h:4632:63: note: in definition of macro ‘alloc_netdev’
> 4632 | alloc_netdev_mqs(sizeof_priv, name, name_assign_type, setup, 1, 1)
> | ^~~~~
> ./include/linux/netdevice.h:4629:44: note: expected ‘void (*)(struct net_device
> *)’ but argument is of type ‘int (*)(struct net_device *)’
> 4629 | void (*setup)(struct net_device *),
> | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
> CC [M] drivers/infiniband/hw/hfi1/vnic_sdma.o
Sorry, this patch is against net-next and you probably tested in Linus'
upstream.
You need to have d160c66cda0ac8614 ("net: Do not return value from
init_dummy_netdev()"), which is in net-next, and has this important
change that is necessary for this patch:
-int init_dummy_netdev(struct net_device *dev);
+void init_dummy_netdev(struct net_device *dev);
If you are OK with a v2, I will fix the topics reported in this thread.
Thank you
Breno
next prev parent reply other threads:[~2024-03-11 15:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 18:29 [PATCH net-next] IB/hfi1: allocate dummy net_device dynamically Breno Leitao
2024-03-10 10:14 ` Leon Romanovsky
2024-03-11 10:08 ` Breno Leitao
2024-03-11 10:22 ` Leon Romanovsky
2024-03-11 18:25 ` Jakub Kicinski
2024-03-12 7:52 ` Leon Romanovsky
2024-03-11 12:05 ` Dennis Dalessandro
2024-03-11 12:17 ` Leon Romanovsky
2024-03-11 15:32 ` Breno Leitao [this message]
2024-03-11 22:22 ` Dennis Dalessandro
2024-03-12 7:55 ` Leon Romanovsky
-- strict thread matches above, loose matches on Subject: below --
2024-04-26 8:56 Breno Leitao
2024-04-30 12:50 ` Leon Romanovsky
2024-04-30 14:03 ` Dennis Dalessandro
2024-04-30 14:10 ` Leon Romanovsky
2024-04-30 14:55 ` Jakub Kicinski
2024-04-30 15:53 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze8j8yWyXCQtwcOJ@gmail.com \
--to=leitao@debian.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).