From: Breno Leitao <leitao@debian.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
kuba@kernel.org, keescook@chromium.org,
"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] IB/hfi1: allocate dummy net_device dynamically
Date: Mon, 11 Mar 2024 03:08:54 -0700 [thread overview]
Message-ID: <Ze7YNu5TrzClQcxy@gmail.com> (raw)
In-Reply-To: <20240310101451.GD12921@unreal>
Hello Leon,
On Sun, Mar 10, 2024 at 12:14:51PM +0200, Leon Romanovsky wrote:
> On Fri, Mar 08, 2024 at 10:29:50AM -0800, Breno Leitao wrote:
> > struct net_device shouldn't be embedded into any structure, instead,
> > the owner should use the priv space to embed their state into net_device.
>
> Why?
From my experience, you can leverage all the helpers to deal with the
relationship between struct net_device and you private structure. Here
are some examples that comes to my mind:
* alloc_netdev() allocates the private structure for you
* netdev_priv() gets the private structure for you
* dev->priv_destructor sets the destructure to be called when the
interface goes away or failures.
> > @@ -360,7 +360,11 @@ int hfi1_alloc_rx(struct hfi1_devdata *dd)
> > if (!rx)
> > return -ENOMEM;
> > rx->dd = dd;
> > - init_dummy_netdev(&rx->rx_napi);
> > + rx->rx_napi = alloc_netdev(sizeof(struct iwl_trans_pcie *),
> > + "dummy", NET_NAME_UNKNOWN,
>
> Will it create multiple "dummy" netdev in the system? Will all devices
> have the same "dummy" name?
Are these devices visible to userspace?
This allocation are using NET_NAME_UNKNOWN, which implies that the
device is not expose to userspace.
Would you prefer a different name?
> > + init_dummy_netdev); + if
> > (!rx->rx_napi) + return -ENOMEM;
>
> You forgot to release previously allocated "rx" here.
Good catch, I will update.
Thanks
next prev parent reply other threads:[~2024-03-11 10:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 18:29 [PATCH net-next] IB/hfi1: allocate dummy net_device dynamically Breno Leitao
2024-03-10 10:14 ` Leon Romanovsky
2024-03-11 10:08 ` Breno Leitao [this message]
2024-03-11 10:22 ` Leon Romanovsky
2024-03-11 18:25 ` Jakub Kicinski
2024-03-12 7:52 ` Leon Romanovsky
2024-03-11 12:05 ` Dennis Dalessandro
2024-03-11 12:17 ` Leon Romanovsky
2024-03-11 15:32 ` Breno Leitao
2024-03-11 22:22 ` Dennis Dalessandro
2024-03-12 7:55 ` Leon Romanovsky
-- strict thread matches above, loose matches on Subject: below --
2024-04-26 8:56 Breno Leitao
2024-04-30 12:50 ` Leon Romanovsky
2024-04-30 14:03 ` Dennis Dalessandro
2024-04-30 14:10 ` Leon Romanovsky
2024-04-30 14:55 ` Jakub Kicinski
2024-04-30 15:53 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze7YNu5TrzClQcxy@gmail.com \
--to=leitao@debian.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).