From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Yuan, Perry" <Perry.Yuan@amd.com>,
"zhida312@outlook.com" <zhida312@outlook.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
Peng Ma <andypma@tencent.com>, "Huang, Ray" <Ray.Huang@amd.com>,
"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
"Limonciello, Mario" <Mario.Limonciello@amd.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp exist
Date: Thu, 16 May 2024 10:42:17 +0200 [thread overview]
Message-ID: <CAJZ5v0gqTnj4Dk844gMMG+rnBvbpA_dGErghTM1PokaDScdBSQ@mail.gmail.com> (raw)
In-Reply-To: <CYYPR12MB86551771F1670A5F9EAC47859CED2@CYYPR12MB8655.namprd12.prod.outlook.com>
On Thu, May 16, 2024 at 10:28 AM Yuan, Perry <Perry.Yuan@amd.com> wrote:
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> > -----Original Message-----
> > From: zhida312@outlook.com <zhida312@outlook.com>
> > Sent: Thursday, May 16, 2024 2:31 PM
> > To: rafael@kernel.org; viresh.kumar@linaro.org
> > Cc: Peng Ma <andypma@tencent.com>; Huang, Ray <Ray.Huang@amd.com>;
> > Shenoy, Gautham Ranjal <gautham.shenoy@amd.com>; Limonciello, Mario
> > <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; linux-
> > pm@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp
> > exist
> >
> > From: andypma <andypma.tencent.com>
The name and e-mail address in the From: header must be the same as in
the Signed-off-by tag, so I've fixed that up.
> > the cpudata memory from kzmalloc in epp init function is not free after epp
> > exist, so we should free it.
> >
> > Signed-off-by: Peng Ma <andypma@tencent.com>
> >
> > Changes from v3 to v4:
> > update subject used git command "git format-patch -1 -v x"
> >
> > Changes from v2 to v3:
> > update Signed-off-by to Peng Ma <andypma@tencent.com>.
> > set a space between if and "(".
> >
> > Changes from v1 to v2:
> > check whether it is empty before releasing
> > set driver_data is NULL after free
> > ---
> > drivers/cpufreq/amd-pstate.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 6a342b0c0140..1b7e82a0ad2e 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct
> > cpufreq_policy *policy)
> >
> > static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) {
> > + struct amd_cpudata *cpudata = policy->driver_data;
> > +
> > + if (cpudata) {
> > + kfree(cpudata);
> > + policy->driver_data = NULL;
> > + }
This does not need to be conditional, because you can pass NULL to
kfree(), but it is correct and since Mario has ACKed it ->
> > +
> > pr_debug("CPU %d exiting\n", policy->cpu);
> > return 0;
> > }
> > --
> > 2.41.0
>
> Looks good now
>
> Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
-> applied as 6.10 material (with edited subject and changelog).
Thanks!
prev parent reply other threads:[~2024-05-16 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 6:30 [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp exist zhida312
2024-05-16 7:47 ` Limonciello, Mario
2024-05-16 8:23 ` Rafael J. Wysocki
2024-05-16 8:28 ` Yuan, Perry
2024-05-16 8:42 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gqTnj4Dk844gMMG+rnBvbpA_dGErghTM1PokaDScdBSQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=Mario.Limonciello@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Ray.Huang@amd.com \
--cc=andypma@tencent.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=zhida312@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).