From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: zhida312@outlook.com, rafael@kernel.org, viresh.kumar@linaro.org,
Peng Ma <andypma@tencent.com>, Huang Rui <ray.huang@amd.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Perry Yuan <perry.yuan@amd.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp exist
Date: Thu, 16 May 2024 10:23:48 +0200 [thread overview]
Message-ID: <CAJZ5v0gWDAws8vOvLXo4WEcz_jr38=87giN=RJSg=O1ec6F4rg@mail.gmail.com> (raw)
In-Reply-To: <a0ecb036-c760-447a-abfb-78fb7928fb9c@amd.com>
On Thu, May 16, 2024 at 9:47 AM Limonciello, Mario
<mario.limonciello@amd.com> wrote:
>
>
>
> On 5/16/2024 1:30 AM, zhida312@outlook.com wrote:
> > From: andypma <andypma.tencent.com>
> >
> > the cpudata memory from kzmalloc in epp init function is
> > not free after epp exist, so we should free it.
> >
> > Signed-off-by: Peng Ma <andypma@tencent.com>
> >
> > Changes from v3 to v4:
> > update subject used git command "git format-patch -1 -v x"
> >
> > Changes from v2 to v3:
> > update Signed-off-by to Peng Ma <andypma@tencent.com>.
> > set a space between if and "(".
> >
> > Changes from v1 to v2:
> > check whether it is empty before releasing
> > set driver_data is NULL after free
> > ---
>
> Thanks for your submission!
>
> I would prefer the change list below the cut list, but otherwise this is
> fine. Maybe Rafael can modify that while committing.
I can do that no problem.
> Acked-by: Mario Limonciello <mario.limonciello@amd.com>
Thanks!
> > drivers/cpufreq/amd-pstate.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 6a342b0c0140..1b7e82a0ad2e 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
> >
> > static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)
> > {
> > + struct amd_cpudata *cpudata = policy->driver_data;
> > +
> > + if (cpudata) {
> > + kfree(cpudata);
> > + policy->driver_data = NULL;
> > + }
> > +
> > pr_debug("CPU %d exiting\n", policy->cpu);
> > return 0;
> > }
next prev parent reply other threads:[~2024-05-16 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 6:30 [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp exist zhida312
2024-05-16 7:47 ` Limonciello, Mario
2024-05-16 8:23 ` Rafael J. Wysocki [this message]
2024-05-16 8:28 ` Yuan, Perry
2024-05-16 8:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0gWDAws8vOvLXo4WEcz_jr38=87giN=RJSg=O1ec6F4rg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=andypma@tencent.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
--cc=zhida312@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).