From: Krzysztof Kozlowski <krzk@kernel.org>
To: "LIANKUN YANG (杨连坤)" <Liankun.Yang@mediatek.com>,
"kishon@kernel.org" <kishon@kernel.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"Mac Shen (沈俊)" <Mac.Shen@mediatek.com>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] drm/mediatek/dp: The register is written with the parsed DTS SSC value.
Date: Thu, 11 Apr 2024 08:37:29 +0200 [thread overview]
Message-ID: <64f6262e-2bef-4603-bd9d-b87926ae88e4@kernel.org> (raw)
In-Reply-To: <bc785b80e109fc04c5973ee4efad115e0c3907c4.camel@mediatek.com>
On 11/04/2024 08:30, LIANKUN YANG (杨连坤) wrote:
> On Wed, 2024-04-03 at 16:56 +0200, Krzysztof Kozlowski wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>> On 03/04/2024 08:41, Krzysztof Kozlowski wrote:
>>> On 03/04/2024 06:05, Liankun Yang wrote:
>>>> [Description]
>>>> Severe screen flickering has been observed on the external display
>>>> when the DP projection function is used with the market expansion
>> dock.
>>>>
>>>
>>>> +if (!strcmp(mode_name, RG_XTP_GLB_TXPLL_SSC_DELTA_RBR)) {
>>>> +regmap_update_bits(dp_phy->regs, ssc_reg_offset,
>>>> + XTP_GLB_TXPLL_SSC_DELTA_RBR_DEFAULT, read_value);
>>>> +} else if (!strcmp(mode_name, RG_XTP_GLB_TXPLL_SSC_DELTA_HBR)) {
>>>> +read_value = read_value << 16 | 0x0000;
>>>> +regmap_update_bits(dp_phy->regs, ssc_reg_offset,
>>>> + XTP_GLB_TXPLL_SSC_DELTA_HBR_DEFAULT, read_value);
>>>> +}
>>>> +
>>>> +return 0;
>>>> +}
>>>> +
>>>> +static struct device_node *mtk_dp_get_ssc_node(struct phy *phy,
>> struct mtk_dp_phy *dp_phy)
>>>> +{
>>>> +struct device_node *mode_node = NULL;
>>>> +
>>>> +mode_node = of_find_node_by_name(dp_phy->dev->of_node,
>> SSC_SETTING);
>>>
>>> ?!?!
>>> You have the node, why do you try to find it?
>>>
>>
>> Wait, that was brainfuck from my side or -ENOCOFFEE. Ignore.
>>
>> I still have a question though, where did you document new ABI:
>> dependency on the node name here?
>>
>> Also, why you are not going through direct children -
>> of_get_child_by_name()?
>>
>> Best regards,
>> Krzysztof
>>
>>
>
> Sorry, there is formatting issue in the previous email.
>
> The dp_phy device has already been registered through the
> mtk_dp_register_phy function in the mtk_dp.c file,
> so it cannot be redefined in the dts. Avoid using of_get_child_by_name
> for this purpose.
>
> To find the node name, utilize of_find_node_by_name since it has
> already been registered.
This does not answer my question at all. You speak about driver, I speak
about ABI and bindings.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2024-04-11 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 4:05 [PATCH v1 1/1] drm/mediatek/dp: The register is written with the parsed DTS SSC value Liankun Yang
2024-04-03 6:41 ` Krzysztof Kozlowski
2024-04-03 14:56 ` Krzysztof Kozlowski
2024-04-11 6:30 ` LIANKUN YANG (杨连坤)
2024-04-11 6:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f6262e-2bef-4603-bd9d-b87926ae88e4@kernel.org \
--to=krzk@kernel.org \
--cc=Chunfeng.Yun@mediatek.com \
--cc=Liankun.Yang@mediatek.com \
--cc=Mac.Shen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).