From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Naga Sureshkumar Relli" <nagasure@xilinx.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"ye xingchen" <ye.xingchen@zte.com.cn>,
"Valentin Korenblit" <vkorenblit@sequans.com>,
"Wang Weiyang" <wangweiyang2@huawei.com>,
"Pali Rohár" <pali@kernel.org>, "Marek Behún" <kabel@kernel.org>,
"Han Xu" <han.xu@nxp.com>,
"Harvey Hunt" <harveyhuntnexus@gmail.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Liang Yang" <liang.yang@amlogic.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Phil Edworthy" <phil.edworthy@renesas.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Chuanhong Guo" <gch981213@gmail.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miaoqian Lin" <linmq006@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Christophe Kerello" <christophe.kerello@foss.st.com>,
"Jack Wang" <jinpu.wang@ionos.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Stefan Agner" <stefan@agner.ch>, "Lucas Stach" <dev@lynxeye.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
Jerome Brunet <jbrunet@baylibre.com>,
linux-amlogic@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org, linux-oxnas@groups.io,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 00/49] mtd: nand: Convert to platform remove callback returning void
Date: Mon, 3 Apr 2023 17:29:59 +0100 [thread overview]
Message-ID: <f881883e-23e1-66e0-78d2-da86533b038f@linaro.org> (raw)
In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de>
On 4/1/23 17:18, Uwe Kleine-König wrote:
> Hello,
>
> this series adapts the platform drivers below drivers/mtd/nand to use the
> .remove_new() callback. Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver core
> doesn't (and cannot) cope for errors during remove. The only effect of a
> non-zero return value in .remove() is that the driver core emits a warning. The
> device is removed anyhow and an early return from .remove() usually yields a
> resource leak.
>
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
>
> As all drivers already return 0 in their .remove callback, they can be
> converted trivially.
>
I'd make a single patch per subsystem for trivial changes, but I don't
mind having them split per driver either:
Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org>
next parent reply other threads:[~2023-04-03 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de>
2023-04-03 16:29 ` Tudor Ambarus [this message]
2023-04-07 8:10 ` [PATCH 00/49] mtd: nand: Convert to platform remove callback returning void Miquel Raynal
[not found] ` <20230408185332.d2g2ao4tdp6ltm4i@pengutronix.de>
2023-04-10 5:08 ` [PATCH] " Vanessa Page
2023-04-10 5:37 ` Tudor Ambarus
2023-04-11 8:20 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f881883e-23e1-66e0-78d2-da86533b038f@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=christophe.kerello@foss.st.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@microchip.com \
--cc=dev@lynxeye.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gch981213@gmail.com \
--cc=geert@linux-m68k.org \
--cc=han.xu@nxp.com \
--cc=harveyhuntnexus@gmail.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=jonathanh@nvidia.com \
--cc=kabel@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=liang.yang@amlogic.com \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-oxnas@groups.io \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nagasure@xilinx.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=pali@kernel.org \
--cc=paul@crapouillou.net \
--cc=phil.edworthy@renesas.com \
--cc=richard@nod.at \
--cc=rogerq@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=vkorenblit@sequans.com \
--cc=vz@mleia.com \
--cc=wangweiyang2@huawei.com \
--cc=wens@csie.org \
--cc=yangyingliang@huawei.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).