From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Lucas Stach" <dev@lynxeye.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Miaoqian Lin" <linmq006@gmail.com>,
"Stefan Agner" <stefan@agner.ch>,
linux-mips@vger.kernel.org,
"Paul Cercueil" <paul@crapouillou.net>,
linux-tegra@vger.kernel.org,
"Liang Yang" <liang.yang@amlogic.com>,
"Naga Sureshkumar Relli" <nagasure@xilinx.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
linux-amlogic@lists.infradead.org,
"Chuanhong Guo" <gch981213@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Heiko Stuebner" <heiko@sntech.de>,
"Marek Behún" <kabel@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Kevin Hilman" <khilman@baylibre.com>,
linux-mediatek@lists.infradead.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"Jack Wang" <jinpu.wang@ionos.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
kernel@pengutronix.de, "Arnd Bergmann" <arnd@arndb.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"ye xingchen" <ye.xingchen@zte.com.cn>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Wang Weiyang" <wangweiyang2@huawei.com>,
"Harvey Hunt" <harveyhuntnexus@gmail.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Han Xu" <han.xu@nxp.com>, "Chen-Yu Tsai" <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Christophe Kerello" <christophe.kerello@foss.st.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Valentin Korenblit" <vkorenblit@sequans.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
linux-renesas-soc@vger.kernel.org,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Richard Weinberger" <richard@nod.at>,
linux-mtd@lists.infradead.org, linux-oxnas@groups.io,
"Pali Rohár" <pali@kernel.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>
Subject: Re: [PATCH] mtd: nand: Convert to platform remove callback returning void
Date: Tue, 11 Apr 2023 10:20:25 +0200 [thread overview]
Message-ID: <20230411102025.6b2fdc9e@xps-13> (raw)
In-Reply-To: <20230408185332.d2g2ao4tdp6ltm4i@pengutronix.de>
Hi Uwe,
u.kleine-koenig@pengutronix.de wrote on Sat, 8 Apr 2023 20:53:32 +0200:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Acked-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>
> Hey Miquel,
>
> On Fri, Apr 07, 2023 at 10:10:43AM +0200, Miquel Raynal wrote:
> > I've looked at the different patches, they look good to me but as they
> > are all trivial and exactly identical, would you mind sending this
> > again all squashed in a single patch? A subsystem-wide conversion seems
> > appropriate. In all cases I plan to take this for the next merge
> > window.
>
> I slightly prefer them separately, because I like small patches and
> because the Acks and Reviews only apply to the individual drivers.
> But I don't mind seriously, so here comes the series squashed into one.
For any non trivial change, I would definitely do that as well.
The thing is, by collecting the tags with b4, you lost all the Acks and
Reviews targets, while we could prevent this, see below.
> While going through the changed, probably the s3c24xx driver (which
> isn't exactly identical to the other changes) could benefit from an
> additional change throwing out the early exit (which---I guess---cannot
> be hit).
Yes, I believe the 'info == NULL' condition is useless, feel free to
drop it in a second patch if you wish.
> BTW, I constructed the lists of acks/reviews myself and found the same
> set. However b4 wailed about each patch claiming:
>
> ✗ BADSIG: DKIM/infradead.org
No idea what this means, any pointer?
> And it didn't like you producing the tags, saying:
>
> NOTE: some trailers ignored due to from/email mismatches:
> ! Trailer: Acked-by: Roger Quadros <rogerq@kernel.org>
> Msg From: Miquel Raynal <miquel.raynal@bootlin.com>
> [...]
Well, yes, I don't expect b4 to read plain english when I say "I
collected them for you" ^^ But at least my list had a '# <area>' suffix
for each of the Acked and Reviewed changes, which is now missing. I
don't know how useful they actually are, but it seems to me that the
information was lost between v1 and v2?
Thanks,
Miquèl
prev parent reply other threads:[~2023-04-11 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de>
2023-04-03 16:29 ` [PATCH 00/49] mtd: nand: Convert to platform remove callback returning void Tudor Ambarus
2023-04-07 8:10 ` Miquel Raynal
[not found] ` <20230408185332.d2g2ao4tdp6ltm4i@pengutronix.de>
2023-04-10 5:08 ` [PATCH] " Vanessa Page
2023-04-10 5:37 ` Tudor Ambarus
2023-04-11 8:20 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411102025.6b2fdc9e@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=christophe.kerello@foss.st.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@microchip.com \
--cc=dev@lynxeye.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gch981213@gmail.com \
--cc=geert@linux-m68k.org \
--cc=han.xu@nxp.com \
--cc=harveyhuntnexus@gmail.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=jonathanh@nvidia.com \
--cc=kabel@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=liang.yang@amlogic.com \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-oxnas@groups.io \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nagasure@xilinx.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=pali@kernel.org \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=rogerq@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=vkorenblit@sequans.com \
--cc=vz@mleia.com \
--cc=wangweiyang2@huawei.com \
--cc=wens@csie.org \
--cc=yangyingliang@huawei.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).