From: Sylvain Petinot <sylvain.petinot@foss.st.com>
To: Rob Herring <robh@kernel.org>
Cc: <benjamin.mugnier@foss.st.com>, <mchehab@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] media: dt-bindings: Add ST VD56G3 camera sensor binding
Date: Fri, 3 May 2024 10:25:06 +0200 [thread overview]
Message-ID: <e38eeaab-f3dd-4129-86aa-9f6bb03bdc40@foss.st.com> (raw)
In-Reply-To: <20240418130916.GA1016598-robh@kernel.org>
Hi Rob,
Thanks for the review.
On 4/18/2024 3:09 PM, Rob Herring wrote:
> On Wed, Apr 17, 2024 at 03:34:52PM +0200, Sylvain Petinot wrote:
>> Add devicetree bindings Documentation for ST VD56G3 & ST VD66GY camera
>> sensors. Update MAINTAINERS file.
>>
>> Signed-off-by: Sylvain Petinot <sylvain.petinot@foss.st.com>
>> ---
>> .../bindings/media/i2c/st,st-vd56g3.yaml | 143 ++++++++++++++++++
>> MAINTAINERS | 9 ++
>> 2 files changed, 152 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml
>> new file mode 100644
>> index 000000000000..6792c02fea5c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml
>> @@ -0,0 +1,143 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +# Copyright (c) 2024 STMicroelectronics SA.
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/i2c/st,st-vd56g3.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: STMicroelectronics VD56G3 Global Shutter Image Sensor
>> +
>> +maintainers:
>> + - Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>> + - Sylvain Petinot <sylvain.petinot@foss.st.com>
>> +
>> +description: |-
>> + The STMicroelectronics VD56G3 is a 1.5 M pixel global shutter image sensor
>> + with an active array size of 1124 x 1364 (portrait orientation).
>> + It is programmable through I2C, the address is fixed to 0x10.
>> + The sensor output is available via CSI-2, which is configured as either 1 or
>> + 2 data lanes.
>> + The sensor provides 8 GPIOS that can be used for either
>> + - frame synchronization (Master: out-sync or Slave: in-sync)
>> + - external LED signal (synchronized with sensor integration periods)
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - st,st-vd56g3
>> + - st,st-vd66gy
>> + description:
>> + Two variants are availables; VD56G3 is a monochrome sensor while VD66GY
>> + is a colour variant.
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + VCORE-supply:
>
> Convention is lowercase.
Ok, updated for V2.
>
>> + description: Digital core power supply (1.15V)
>> +
>> + VDDIO-supply:
>> + description: Digital IO power supply (1.8V)
>> +
>> + VANA-supply:
>> + description: Analog power supply (2.8V)
>> +
>> + reset-gpios:
>> + description: Sensor reset active low GPIO (XSHUTDOWN)
>> + maxItems: 1
>> +
>> + st,leds:
>> + description:
>> + Sensor's GPIOs used for external LED control.
>> + Signal being the enveloppe of the integration time.
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + minItems: 1
>> + maxItems: 8
>> + items:
>> + minimum: 0
>> + maximum: 7
>> +
>> + port:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> +
>> + properties:
>> + endpoint:
>> + $ref: /schemas/media/video-interfaces.yaml#
>> + unevaluatedProperties: false
>> +
>> + properties:
>> + clock-lanes:
>> + const: 0
>
> If required and only 1 possible value, why does this need to be in DT?
Indeed... it probably serves no purpose.
I added it to be consistent with the data-lanes that can be
reordered/swapped. Will be dropped in V2.
>
>> +
>> + data-lanes:
>> + minItems: 1
>> + maxItems: 2
>> + items:
>> + enum: [1, 2]
>> +
>> + link-frequencies:
>> + minItems: 1
>> + maxItems: 1
>> + items:
>> + enum: [402000000, 750000000]
>> +
>> + lane-polarities:
>> + minItems: 1
>> + maxItems: 3
>> + items:
>> + enum: [0, 1]
>
> video-interfaces.yaml already defines this constraint, so you just need
> to define how many entries.
Ok, updated for V2.
>
>> + description: Any lane can be inverted or not.
>> +
>> + required:
>> + - clock-lanes
>> + - data-lanes
>> + - link-frequencies
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - VCORE-supply
>> + - VDDIO-supply
>> + - VANA-supply
>> + - reset-gpios
>> + - port
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + vd56g3: camera-sensor@10 {
>
> Drop unused labels.
Ok
>
>> + compatible = "st,st-vd56g3";
>> + reg = <0x10>;
>> +
>> + clocks = <&camera_clk_12M>;
>> +
>> + VCORE-supply = <&camera_vcore_v1v15>;
>> + VDDIO-supply = <&camera_vddio_v1v8>;
>> + VANA-supply = <&camera_vana_v2v8>;
>> +
>> + reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
>> + st,leds = <6>;
>> +
>> + port {
>> + vd56g3_ep: endpoint {
>> + clock-lanes = <0>;
>> + data-lanes = <1 2>;
>> + link-frequencies =
>> + /bits/ 64 <402000000>;
>> + remote-endpoint = <&csiphy0_ep>;
>> + };
>> + };
>> + };
>> + };
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7c121493f43d..991e65627e18 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -20868,6 +20868,15 @@ S: Maintained
>> F: Documentation/hwmon/stpddc60.rst
>> F: drivers/hwmon/pmbus/stpddc60.c
>>
>> +ST VD56G3 DRIVER
>> +M: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>> +M: Sylvain Petinot <sylvain.petinot@foss.st.com>
>> +L: linux-media@vger.kernel.org
>> +S: Maintained
>> +T: git git://linuxtv.org/media_tree.git
>
> This should be covered by the media maintainer entry.
I'm really sorry but I don't see what you're referring to. Can you point
me to the correct direction please ?
>
>> +F: Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml
>> +F: drivers/media/i2c/st-vd56g3.c
>> +
>> ST VGXY61 DRIVER
>> M: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>> M: Sylvain Petinot <sylvain.petinot@foss.st.com>
>> --
>> 2.17.1
>>
--
Sylvain
next prev parent reply other threads:[~2024-05-03 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 13:34 [PATCH 0/2] media: Add driver for ST VD56G3 camera sensor Sylvain Petinot
2024-04-17 13:34 ` [PATCH 1/2] media: dt-bindings: Add ST VD56G3 camera sensor binding Sylvain Petinot
2024-04-18 13:09 ` Rob Herring
2024-05-03 8:25 ` Sylvain Petinot [this message]
2024-05-03 16:06 ` Krzysztof Kozlowski
2024-05-27 19:05 ` Krzysztof Kozlowski
2024-04-24 20:46 ` Sakari Ailus
2024-05-03 8:40 ` Sylvain Petinot
2024-04-17 13:34 ` [PATCH 2/2] media: i2c: Add driver for ST VD56G3 camera sensor Sylvain Petinot
2024-04-18 5:39 ` kernel test robot
2024-04-18 9:17 ` Tommaso Merciai
2024-05-03 7:54 ` Sylvain Petinot
2024-05-06 8:23 ` Tommaso Merciai
2024-04-24 21:12 ` Sakari Ailus
2024-05-03 10:10 ` Sylvain Petinot
2024-05-13 13:37 ` Benjamin Mugnier
2024-05-27 7:31 ` Sakari Ailus
2024-05-27 7:44 ` Benjamin Mugnier
2024-05-27 7:45 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e38eeaab-f3dd-4129-86aa-9f6bb03bdc40@foss.st.com \
--to=sylvain.petinot@foss.st.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).