From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Alexandre Mergnat" <amergnat@baylibre.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Lee Jones" <lee@kernel.org>, "Flora Fu" <flora.fu@mediatek.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4 07/16] ASoC: mediatek: mt8365: Add ADDA DAI support
Date: Mon, 20 May 2024 12:27:18 +0200 [thread overview]
Message-ID: <a693b696-92cf-48cf-8c9d-17aa7f182d98@collabora.com> (raw)
In-Reply-To: <20240226-audio-i350-v4-7-082b22186d4c@baylibre.com>
Il 26/04/24 19:22, Alexandre Mergnat ha scritto:
> Add ADDA Device Audio Interface support for MT8365 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> sound/soc/mediatek/mt8365/mt8365-dai-adda.c | 315 ++++++++++++++++++++++++++++
> 1 file changed, 315 insertions(+)
>
> diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-adda.c b/sound/soc/mediatek/mt8365/mt8365-dai-adda.c
> new file mode 100644
> index 000000000000..65d45010ac90
> --- /dev/null
> +++ b/sound/soc/mediatek/mt8365/mt8365-dai-adda.c
> @@ -0,0 +1,315 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Mediatek 8365 ALSA SoC Audio DAI ADDA Control
> + *
> + * Copyright (c) 2024 MediaTek Inc.
> + * Authors: Jia Zeng <jia.zeng@mediatek.com>
> + * Alexandre Mergnat <amergnat@baylibre.com>
> + */
> +
> +#include <linux/bitops.h>
> +#include <linux/regmap.h>
> +#include <sound/pcm_params.h>
> +#include "mt8365-afe-clk.h"
> +#include "mt8365-afe-common.h"
> +#include "../common/mtk-dai-adda-common.h"
> +
> +static int adda_afe_on_ref_cnt;
> +
> +/* DAI Drivers */
> +
> +static int mt8365_dai_set_adda_out(struct mtk_base_afe *afe, unsigned int rate)
> +{
> + unsigned int val;
> +
if (rate == 8000 || rate == 16000)
val = AFE_ADDA_DL_VOICE_DATA;
else
val = 0;
> + switch (rate) {
> + case 8000:
> + val = AFE_ADDA_DL_VOICE_DATA;
> + break;
> + case 16000:
> + val = AFE_ADDA_DL_VOICE_DATA;
> + break;
> + default:
> + val = 0;
> + }
> +
> + val |= FIELD_PREP(AFE_ADDA_DL_SAMPLING_RATE,
> + mtk_adda_dl_rate_transform(afe, rate));
> + val |= AFE_ADDA_DL_8X_UPSAMPLE |
> + AFE_ADDA_DL_MUTE_OFF_CH1 |
> + AFE_ADDA_DL_MUTE_OFF_CH2 |
> + AFE_ADDA_DL_DEGRADE_GAIN;
> +
> + regmap_update_bits(afe->regmap, AFE_ADDA_PREDIS_CON0, 0xffffffff, 0);
> + regmap_update_bits(afe->regmap, AFE_ADDA_PREDIS_CON1, 0xffffffff, 0);
> + regmap_update_bits(afe->regmap, AFE_ADDA_DL_SRC2_CON0, 0xffffffff, val);
> + /* SA suggest apply -0.3db to audio/speech path */
> + regmap_update_bits(afe->regmap, AFE_ADDA_DL_SRC2_CON1,
> + 0xffffffff, 0xf74f0000);
> + /* SA suggest use default value for sdm */
> + regmap_update_bits(afe->regmap, AFE_ADDA_DL_SDM_DCCOMP_CON,
> + 0xffffffff, 0x0700701e);
> +
> + return 0;
> +}
> +
> +static int mt8365_dai_set_adda_in(struct mtk_base_afe *afe, unsigned int rate)
> +{
> + unsigned int val;
> +
> + val = FIELD_PREP(AFE_ADDA_UL_SAMPLING_RATE,
> + mtk_adda_ul_rate_transform(afe, rate));
> + regmap_update_bits(afe->regmap, AFE_ADDA_UL_SRC_CON0,
> + AFE_ADDA_UL_SAMPLING_RATE, val);
> + /* Using Internal ADC */
> + regmap_update_bits(afe->regmap, AFE_ADDA_TOP_CON0, 0x1, 0x0);
> +
> + return 0;
> +}
> +
> +int mt8365_dai_enable_adda_on(struct mtk_base_afe *afe)
> +{
> + unsigned long flags;
> + struct mt8365_afe_private *afe_priv = afe->platform_priv;
> +
> + spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags);
> +
> + adda_afe_on_ref_cnt++;
> + if (adda_afe_on_ref_cnt == 1)
> + regmap_update_bits(afe->regmap, AFE_ADDA_UL_DL_CON0,
> + AFE_ADDA_UL_DL_ADDA_AFE_ON,
> + AFE_ADDA_UL_DL_ADDA_AFE_ON);
> +
> + spin_unlock_irqrestore(&afe_priv->afe_ctrl_lock, flags);
> +
> + return 0;
> +}
> +
> +int mt8365_dai_disable_adda_on(struct mtk_base_afe *afe)
> +{
> + unsigned long flags;
> + struct mt8365_afe_private *afe_priv = afe->platform_priv;
> +
> + spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags);
> +
> + adda_afe_on_ref_cnt--;
> + if (adda_afe_on_ref_cnt == 0)
> + regmap_update_bits(afe->regmap, AFE_ADDA_UL_DL_CON0,
> + AFE_ADDA_UL_DL_ADDA_AFE_ON,
> + ~AFE_ADDA_UL_DL_ADDA_AFE_ON);
> + else if (adda_afe_on_ref_cnt < 0)
> + adda_afe_on_ref_cnt = 0;
Should we dev_warn() here? The refcount should never be less than zero - if it is,
then there's some issue somewhere that must be solved.
> +
> + spin_unlock_irqrestore(&afe_priv->afe_ctrl_lock, flags);
> +
> + return 0;
> +}
> +
Cheers,
Angelo
next prev parent reply other threads:[~2024-05-20 10:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 17:22 [PATCH v4 00/16] Add audio support for the MediaTek Genio 350-evk board Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 01/16] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document Alexandre Mergnat
2024-04-29 5:58 ` Krzysztof Kozlowski
2024-04-26 17:22 ` [PATCH v4 02/16] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document Alexandre Mergnat
2024-04-29 5:59 ` Krzysztof Kozlowski
2024-04-26 17:22 ` [PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC Alexandre Mergnat
2024-04-29 6:03 ` Krzysztof Kozlowski
2024-04-26 17:22 ` [PATCH v4 04/16] ASoC: mediatek: mt8365: Add common header Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control Alexandre Mergnat
2024-04-29 14:44 ` Mark Brown
2024-05-20 10:38 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 06/16] ASoC: mediatek: mt8365: Add I2S DAI support Alexandre Mergnat
2024-05-20 10:27 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 07/16] ASoC: mediatek: mt8365: Add ADDA " Alexandre Mergnat
2024-05-20 10:27 ` AngeloGioacchino Del Regno [this message]
2024-05-22 9:23 ` Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 08/16] ASoC: mediatek: mt8365: Add DMIC " Alexandre Mergnat
2024-05-20 10:27 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 09/16] ASoC: mediatek: mt8365: Add PCM " Alexandre Mergnat
2024-05-20 10:28 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 10/16] ASoc: mediatek: mt8365: Add a specific soundcard for EVK amergnat
2024-05-20 10:30 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 11/16] ASoC: mediatek: mt8365: Add platform driver Alexandre Mergnat
2024-05-20 10:32 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 12/16] ASoC: codecs: add MT6357 support amergnat
2024-04-26 17:22 ` [PATCH v4 13/16] ASoC: mediatek: Add MT8365 support Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 14/16] arm64: defconfig: enable mt8365 sound Alexandre Mergnat
2024-05-20 10:39 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 15/16] arm64: dts: mediatek: add afe support for mt8365 SoC Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 16/16] arm64: dts: mediatek: add audio support for mt8365-evk Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a693b696-92cf-48cf-8c9d-17aa7f182d98@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=flora.fu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).