From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Alexandre Mergnat" <amergnat@baylibre.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Lee Jones" <lee@kernel.org>, "Flora Fu" <flora.fu@mediatek.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
Date: Mon, 29 Apr 2024 08:03:24 +0200 [thread overview]
Message-ID: <6d21da37-8be7-467c-8878-d57af0b0201b@kernel.org> (raw)
In-Reply-To: <20240226-audio-i350-v4-3-082b22186d4c@baylibre.com>
On 26/04/2024 19:22, Alexandre Mergnat wrote:
> regulators:
> type: object
> $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml
> @@ -83,6 +111,12 @@ examples:
> interrupt-controller;
> #interrupt-cells = <2>;
>
> + audio-codec {
> + mediatek,micbias0-microvolt = <1700000>;
> + mediatek,micbias1-microvolt = <1700000>;
> + vaud28-supply = <&mt6357_vaud28_reg>;
And now you should see how odd it looks. Supplies are part of entire
chip, not subblock, even if they supply dedicated domain within that chip.
That's why I asked to put it in the parent node.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-29 6:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 17:22 [PATCH v4 00/16] Add audio support for the MediaTek Genio 350-evk board Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 01/16] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document Alexandre Mergnat
2024-04-29 5:58 ` Krzysztof Kozlowski
2024-04-26 17:22 ` [PATCH v4 02/16] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document Alexandre Mergnat
2024-04-29 5:59 ` Krzysztof Kozlowski
2024-04-26 17:22 ` [PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC Alexandre Mergnat
2024-04-29 6:03 ` Krzysztof Kozlowski [this message]
2024-04-26 17:22 ` [PATCH v4 04/16] ASoC: mediatek: mt8365: Add common header Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control Alexandre Mergnat
2024-04-29 14:44 ` Mark Brown
2024-05-20 10:38 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 06/16] ASoC: mediatek: mt8365: Add I2S DAI support Alexandre Mergnat
2024-05-20 10:27 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 07/16] ASoC: mediatek: mt8365: Add ADDA " Alexandre Mergnat
2024-05-20 10:27 ` AngeloGioacchino Del Regno
2024-05-22 9:23 ` Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 08/16] ASoC: mediatek: mt8365: Add DMIC " Alexandre Mergnat
2024-05-20 10:27 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 09/16] ASoC: mediatek: mt8365: Add PCM " Alexandre Mergnat
2024-05-20 10:28 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 10/16] ASoc: mediatek: mt8365: Add a specific soundcard for EVK amergnat
2024-05-20 10:30 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 11/16] ASoC: mediatek: mt8365: Add platform driver Alexandre Mergnat
2024-05-20 10:32 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 12/16] ASoC: codecs: add MT6357 support amergnat
2024-04-26 17:22 ` [PATCH v4 13/16] ASoC: mediatek: Add MT8365 support Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 14/16] arm64: defconfig: enable mt8365 sound Alexandre Mergnat
2024-05-20 10:39 ` AngeloGioacchino Del Regno
2024-04-26 17:22 ` [PATCH v4 15/16] arm64: dts: mediatek: add afe support for mt8365 SoC Alexandre Mergnat
2024-04-26 17:22 ` [PATCH v4 16/16] arm64: dts: mediatek: add audio support for mt8365-evk Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d21da37-8be7-467c-8878-d57af0b0201b@kernel.org \
--to=krzk@kernel.org \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=flora.fu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).